Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1715653002: Fix non-Oilpan ref pointer usage over DOMTokenLists. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
Yoav Weiss
CC:
chromium-reviews, Yoav Weiss, blink-reviews-html_chromium.org, gavinp+prerender_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix non-Oilpan ref pointer usage over DOMTokenLists. R= BUG=584612 NOTRY=true Committed: https://crrev.com/b80a7c3297024a9be31c9c24046b9f8701aee0be Cr-Commit-Position: refs/heads/master@{#376434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/DOMTokenList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ElementRareData.h View 3 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/ClassList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/ClassList.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/RelList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/RelList.cpp View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Yoav Weiss
LGTM
4 years, 10 months ago (2016-02-19 11:05:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715653002/1
4 years, 10 months ago (2016-02-19 11:47:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715653002/1
4 years, 10 months ago (2016-02-19 12:27:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 14:31:04 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 14:32:07 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b80a7c3297024a9be31c9c24046b9f8701aee0be
Cr-Commit-Position: refs/heads/master@{#376434}

Powered by Google App Engine
This is Rietveld 408576698