Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/core/dom/DOMTokenList.h

Issue 1715653002: Fix non-Oilpan ref pointer usage over DOMTokenLists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ElementRareData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 USING_FAST_MALLOC_WILL_BE_REMOVED(DOMTokenList); 52 USING_FAST_MALLOC_WILL_BE_REMOVED(DOMTokenList);
53 WTF_MAKE_NONCOPYABLE(DOMTokenList); 53 WTF_MAKE_NONCOPYABLE(DOMTokenList);
54 public: 54 public:
55 static PassRefPtrWillBeRawPtr<DOMTokenList> create(DOMTokenListObserver* obs erver = nullptr) 55 static PassRefPtrWillBeRawPtr<DOMTokenList> create(DOMTokenListObserver* obs erver = nullptr)
56 { 56 {
57 return adoptRefWillBeNoop(new DOMTokenList(observer)); 57 return adoptRefWillBeNoop(new DOMTokenList(observer));
58 } 58 }
59 59
60 virtual ~DOMTokenList() { } 60 virtual ~DOMTokenList() { }
61 61
62 #if !ENABLE(OILPAN)
63 virtual void ref() { RefCounted<DOMTokenList>::ref(); }
64 virtual void deref() { RefCounted<DOMTokenList>::deref(); }
65 #endif
66
62 virtual unsigned length() const { return m_tokens.size(); } 67 virtual unsigned length() const { return m_tokens.size(); }
63 virtual const AtomicString item(unsigned index) const; 68 virtual const AtomicString item(unsigned index) const;
64 69
65 bool contains(const AtomicString&, ExceptionState&) const; 70 bool contains(const AtomicString&, ExceptionState&) const;
66 virtual void add(const Vector<String>&, ExceptionState&); 71 virtual void add(const Vector<String>&, ExceptionState&);
67 void add(const AtomicString&, ExceptionState&); 72 void add(const AtomicString&, ExceptionState&);
68 virtual void remove(const Vector<String>&, ExceptionState&); 73 virtual void remove(const Vector<String>&, ExceptionState&);
69 void remove(const AtomicString&, ExceptionState&); 74 void remove(const AtomicString&, ExceptionState&);
70 bool toggle(const AtomicString&, ExceptionState&); 75 bool toggle(const AtomicString&, ExceptionState&);
71 bool toggle(const AtomicString&, bool force, ExceptionState&); 76 bool toggle(const AtomicString&, bool force, ExceptionState&);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 private: 111 private:
107 IterationSource* startIteration(ScriptState*, ExceptionState&) override; 112 IterationSource* startIteration(ScriptState*, ExceptionState&) override;
108 SpaceSplitString m_tokens; 113 SpaceSplitString m_tokens;
109 AtomicString m_value; 114 AtomicString m_value;
110 RawPtrWillBeWeakMember<DOMTokenListObserver> m_observer; 115 RawPtrWillBeWeakMember<DOMTokenListObserver> m_observer;
111 }; 116 };
112 117
113 } // namespace blink 118 } // namespace blink
114 119
115 #endif // DOMTokenList_h 120 #endif // DOMTokenList_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/ElementRareData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698