Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 171563007: Revert of Updating Blink-side WebGamepad interface (Closed)

Created:
6 years, 10 months ago by bajones
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Revert of Updating Blink-side WebGamepad interface (https://codereview.chromium.org/170993002/) Reason for revert: Compiler errors on chromium.webkit waterfall Original issue's description: > Updating Blink-side Gamepad API to match latest spec > > BUG=344556 > R=abarth@chromium.org, scottmg@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167539 TBR=scottmg@chromium.org,eseidel@chromium.org,abarth@chromium.org NOTREECHECKS=true NOTRY=true BUG=344556

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -66 lines) Patch
M Source/modules/gamepad/Gamepad.h View 3 chunks +0 lines, -13 lines 0 comments Download
M Source/modules/gamepad/Gamepad.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/modules/gamepad/Gamepad.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/gamepad/NavigatorGamepad.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M public/platform/WebGamepad.h View 3 chunks +1 line, -34 lines 0 comments Download
M public/platform/WebGamepads.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bajones
Created Revert of Updating Blink-side WebGamepad interface
6 years, 10 months ago (2014-02-20 22:14:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/171563007/1
6 years, 10 months ago (2014-02-20 22:14:41 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 22:14:43 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 22:14:44 UTC) #4
Failed to apply patch for Source/modules/gamepad/Gamepad.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/modules/gamepad/Gamepad.cpp
  Hunk #1 FAILED at 44.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/modules/gamepad/Gamepad.cpp.rej

Patch:       Source/modules/gamepad/Gamepad.cpp
Index: Source/modules/gamepad/Gamepad.cpp
diff --git a/Source/modules/gamepad/Gamepad.cpp
b/Source/modules/gamepad/Gamepad.cpp
index
fbbfb9b53d9b476907a24fd0912332de868746f4..c83ccaf90a457ce81bcf3bc81f7680410dfefc00
100644
--- a/Source/modules/gamepad/Gamepad.cpp
+++ b/Source/modules/gamepad/Gamepad.cpp
@@ -44,21 +44,12 @@
         std::copy(data, data + count, m_axes.begin());
 }
 
-#if defined(ENABLE_NEW_GAMEPAD_API)
-void Gamepad::buttons(unsigned count, blink::WebGamepadButton* data)
-{
-    m_buttons.resize(count);
-    for (unsigned i = 0; i < count; ++i)
-        m_buttons[i] = data[i].value;
-}
-#else
 void Gamepad::buttons(unsigned count, float* data)
 {
     m_buttons.resize(count);
     if (count)
         std::copy(data, data + count, m_buttons.begin());
 }
-#endif
 
 Gamepad::~Gamepad()
 {

Powered by Google App Engine
This is Rietveld 408576698