Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.h

Issue 1715573002: Replicating LayoutDumpFlags across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicating-pixel-dump-flag
Patch Set: Maybe this is ready for review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.h
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
index 8059eb7c2fb83cb4f323b47aa01f1469e87ea7b7..c8e4a9cfc79c8852d2ec7ff8fc1aac95505df5a4 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.h
@@ -8,15 +8,16 @@
#include "base/macros.h"
#include "content/public/renderer/render_frame_observer.h"
-namespace test_runner {
-struct LayoutDumpFlags;
-}
-
namespace IPC {
class Message;
} // namespace IPC
+namespace base {
+class DictionaryValue;
+} // namespace
+
namespace content {
+struct ShellTestConfiguration;
class RenderFrame;
struct ShellTestConfiguration;
@@ -28,10 +29,14 @@ class LayoutTestRenderFrameObserver : public RenderFrameObserver {
bool OnMessageReceived(const IPC::Message& message) override;
private:
- void OnLayoutDumpRequest(
- const test_runner::LayoutDumpFlags& layout_dump_flags);
+ void OnLayoutDumpRequest();
void OnSetTestConfiguration(const ShellTestConfiguration& test_config);
- void OnReplicateTestConfiguration(const ShellTestConfiguration& test_config);
+ void OnReplicateTestConfiguration(
+ const ShellTestConfiguration& test_config,
+ const base::DictionaryValue& accumulated_layout_dump_flags_changes);
+ void OnReplicateLayoutDumpFlagsChanges(
+ const base::DictionaryValue& changed_layout_dump_flags,
+ const std::string& change_originator_guid);
DISALLOW_COPY_AND_ASSIGN(LayoutTestRenderFrameObserver);
};

Powered by Google App Engine
This is Rietveld 408576698