Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc

Issue 1715573002: Replicating LayoutDumpFlags across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicating-pixel-dump-flag
Patch Set: Maybe this is ready for review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
diff --git a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
index 7376b367b9d2a305dd5f65a87c21628cb9693798..d9f5e1a29abf40c2dd360f947ce684f072de8dfe 100644
--- a/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
+++ b/content/shell/renderer/layout_test/layout_test_render_frame_observer.cc
@@ -34,6 +34,8 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(LayoutTestRenderFrameObserver, message)
IPC_MESSAGE_HANDLER(ShellViewMsg_LayoutDumpRequest, OnLayoutDumpRequest)
+ IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateLayoutDumpFlagsChanges,
+ OnReplicateLayoutDumpFlagsChanges)
IPC_MESSAGE_HANDLER(ShellViewMsg_ReplicateTestConfiguration,
OnReplicateTestConfiguration)
IPC_MESSAGE_HANDLER(ShellViewMsg_SetTestConfiguration,
@@ -44,18 +46,24 @@ bool LayoutTestRenderFrameObserver::OnMessageReceived(
return handled;
}
-void LayoutTestRenderFrameObserver::OnLayoutDumpRequest(
- const test_runner::LayoutDumpFlags& layout_dump_flags) {
+void LayoutTestRenderFrameObserver::OnLayoutDumpRequest() {
+ const test_runner::LayoutDumpFlags& layout_dump_flags =
+ LayoutTestRenderProcessObserver::GetInstance()
+ ->test_interfaces()
+ ->TestRunner()
+ ->GetLayoutDumpFlags();
std::string dump =
test_runner::DumpLayout(render_frame()->GetWebFrame(), layout_dump_flags);
Send(new ShellViewHostMsg_LayoutDumpResponse(routing_id(), dump));
}
void LayoutTestRenderFrameObserver::OnReplicateTestConfiguration(
- const ShellTestConfiguration& test_config) {
+ const ShellTestConfiguration& test_config,
+ const base::DictionaryValue& accumulated_layout_dump_flags_changes) {
LayoutTestRenderProcessObserver::GetInstance()
->main_test_runner()
- ->OnReplicateTestConfiguration(test_config);
+ ->OnReplicateTestConfiguration(test_config,
+ accumulated_layout_dump_flags_changes);
}
void LayoutTestRenderFrameObserver::OnSetTestConfiguration(
@@ -65,4 +73,13 @@ void LayoutTestRenderFrameObserver::OnSetTestConfiguration(
->OnSetTestConfiguration(test_config);
}
+void LayoutTestRenderFrameObserver::OnReplicateLayoutDumpFlagsChanges(
+ const base::DictionaryValue& changed_layout_dump_flags,
+ const std::string& change_originator_guid) {
+ LayoutTestRenderProcessObserver::GetInstance()
+ ->main_test_runner()
+ ->OnReplicateLayoutDumpFlagsChanges(changed_layout_dump_flags,
+ change_originator_guid);
+}
+
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698