Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1715543003: [runtime] cleanup handling of private symbol + proxy (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] cleanup handling of private symbol + proxy BUG= Committed: https://crrev.com/3fa6a3caf2f0194169093c15bc59e768df76f712 Cr-Commit-Position: refs/heads/master@{#34150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M src/lookup.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/objects.cc View 5 chunks +10 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-19 10:16:48 UTC) #2
Jakob Kummerow
lgtm
4 years, 10 months ago (2016-02-19 10:34:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715543003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715543003/1
4 years, 10 months ago (2016-02-19 11:13:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 11:44:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 11:44:15 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fa6a3caf2f0194169093c15bc59e768df76f712
Cr-Commit-Position: refs/heads/master@{#34150}

Powered by Google App Engine
This is Rietveld 408576698