Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: src/lookup.cc

Issue 1715543003: [runtime] cleanup handling of private symbol + proxy (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.cc
diff --git a/src/lookup.cc b/src/lookup.cc
index 1265d9056ea74f046584ebb21248a882c77bf9f0..32c829b1b4a8cb5b57fcd47e4dd6e867a2577b32 100644
--- a/src/lookup.cc
+++ b/src/lookup.cc
@@ -596,7 +596,6 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* const map,
switch (state_) {
case NOT_FOUND:
if (map->IsJSProxyMap()) {
- // Do not leak private property names.
if (IsElement() || !name_->IsPrivate()) return JSPROXY;
}
if (map->is_access_check_needed()) {
@@ -606,9 +605,7 @@ LookupIterator::State LookupIterator::LookupInHolder(Map* const map,
case ACCESS_CHECK:
if (check_interceptor() && HasInterceptor(map) &&
!SkipInterceptor(JSObject::cast(holder))) {
- // Do not leak private property names.
- if (!name_.is_null() && name_->IsPrivate()) return NOT_FOUND;
- return INTERCEPTOR;
+ if (IsElement() || !name_->IsPrivate()) return INTERCEPTOR;
}
// Fall through.
case INTERCEPTOR:
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698