V8 Binding: Introduce toNativeWithTypeCheck

V8 Binding: Introduce toNativeWithTypeCheck

Currently V8 binding has a lot of code that has the following pattern:

  XXX* imp = 0;
  if (V8XXX::hasInstance(wrapper))
    imp = V8XXX::toNative(wrapper);

This CL implements V8XXX::toNativeWithTypeCheck() and enables developers write the above code like this:

  XXX* imp = toNativeWithTypeCheck(wrapper);

(The real intention of this CL is a preparation for removing worldType() from the code base, but it's hard to explain the relationship at this point.)

BUG=341032
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167512

[haraken, 2014-02-19 02:47:22]

PTAL

[dcarney, 2014-02-19 08:00:38]

lgtm

[haraken, 2014-02-19 08:46:09]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-19 08:46:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/130001

[commit-bot: I haz the power, 2014-02-19 10:32:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-19 10:32:32]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[haraken, 2014-02-19 11:34:54]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-19 11:35:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/310001

[Paweł Hajdan Jr., 2014-02-19 19:31:00]

The CQ bit was unchecked by phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-02-19 19:32:31]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-02-19 21:54:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/310001

[commit-bot: I haz the power, 2014-02-19 23:00:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/310001

[commit-bot: I haz the power, 2014-02-20 03:03:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 03:03:10]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[haraken, 2014-02-20 09:26:54]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-20 09:27:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/310001

[commit-bot: I haz the power, 2014-02-20 09:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 09:27:29]

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #4 FAILED at 1604.
  1 out of 19 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObject.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObject.cpp
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp
b/Source/bindings/tests/results/V8TestObject.cpp
index
29714c00a4fb510f89a835d1bd2a334ae4fa1c2e..4d5c5bea682b848e72113b1e255731c5b4584bcb
100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -544,7 +544,7 @@ static void
testObjAttrAttributeGetterCallback(v8::Local<v8::String>, const v8::
 static void testObjAttrAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setTestObjAttr(WTF::getPtr(cppValue));
 }
 
@@ -600,7 +600,7 @@ static void
XMLObjAttrAttributeGetterCallback(v8::Local<v8::String>, const v8::P
 static void XMLObjAttrAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setXMLObjAttr(WTF::getPtr(cppValue));
 }
 
@@ -1576,7 +1576,7 @@ static void
withExecutionContextAttributeAttributeGetterCallback(v8::Local<v8::S
 static void withExecutionContextAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
     imp->setWithExecutionContextAttribute(scriptContext,
WTF::getPtr(cppValue));
 }
@@ -1604,7 +1604,7 @@ static void
withActiveWindowAndFirstWindowAttributeAttributeGetterCallback(v8::L
 static void
withActiveWindowAndFirstWindowAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
    
imp->setWithActiveWindowAndFirstWindowAttribute(activeDOMWindow(info.GetIsolate()),
firstDOMWindow(info.GetIsolate()), WTF::getPtr(cppValue));
 }
 
@@ -1635,7 +1635,7 @@ static void
withScriptStateAttributeRaisesAttributeGetterCallback(v8::Local<v8::
 static void withScriptStateAttributeRaisesAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setWithScriptStateAttributeRaises(WTF::getPtr(cppValue));
 }
 
@@ -2497,7 +2497,7 @@ static void
perWorldAttributeAttributeGetterCallback(v8::Local<v8::String>, cons
 static void perWorldAttributeAttributeSetter(v8::Local<v8::Value> jsValue,
const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setPerWorldAttribute(WTF::getPtr(cppValue));
 }
 
@@ -2524,7 +2524,7 @@ static void
perWorldAttributeAttributeGetterCallbackForMainWorld(v8::Local<v8::S
 static void perWorldAttributeAttributeSetterForMainWorld(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setPerWorldAttribute(WTF::getPtr(cppValue));
 }
 
@@ -3208,7 +3208,7 @@ static void voidMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>&
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     imp->voidMethodWithArgs(longArg, strArg, objArg);
 }
 
@@ -3243,7 +3243,7 @@ static void longMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>&
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     v8SetReturnValueInt(info, imp->longMethodWithArgs(longArg, strArg,
objArg));
 }
 
@@ -3279,7 +3279,7 @@ static void objMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>& i
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     v8SetReturnValue(info, imp->objMethodWithArgs(longArg, strArg, objArg));
 }
 
@@ -3361,7 +3361,7 @@ static void methodThatRequiresAllArgsAndThrowsMethod(const
v8::FunctionCallbackI
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[0]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[1],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[1]));
     RefPtr<TestObj> result = imp->methodThatRequiresAllArgsAndThrows(strArg,
objArg, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
@@ -4280,7 +4280,7 @@ static void overloadedMethod3Method(const
v8::FunctionCallbackInfo<v8::Value>& i
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     imp->overloadedMethod(objArg);
 }
 
@@ -4354,7 +4354,7 @@ static void overloadedMethodA1Method(const
v8::FunctionCallbackInfo<v8::Value>&
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     if (UNLIKELY(info.Length() <= 1)) {
         imp->overloadedMethodA(objArg);
         return;
@@ -4370,7 +4370,7 @@ static void overloadedMethodA2Method(const
v8::FunctionCallbackInfo<v8::Value>&
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
     imp->overloadedMethodA(objArg, strArg);
 }
@@ -4658,7 +4658,7 @@ static void domStringListFunctionMethod(const
v8::FunctionCallbackInfo<v8::Value
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(DOMStringList*, values,
V8DOMStringList::hasInstance(info[0], info.GetIsolate()) ? V8DOMStringLi…
(message too large)

[haraken, 2014-02-20 09:35:01]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-20 09:35:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/550001

[commit-bot: I haz the power, 2014-02-20 09:35:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 09:35:29]

Failed to apply patch for Source/bindings/tests/results/V8TestObject.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/tests/results/V8TestObject.cpp
  Hunk #4 FAILED at 1604.
  1 out of 19 hunks FAILED -- saving rejects to file
Source/bindings/tests/results/V8TestObject.cpp.rej

Patch:       Source/bindings/tests/results/V8TestObject.cpp
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp
b/Source/bindings/tests/results/V8TestObject.cpp
index
29714c00a4fb510f89a835d1bd2a334ae4fa1c2e..4d5c5bea682b848e72113b1e255731c5b4584bcb
100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -544,7 +544,7 @@ static void
testObjAttrAttributeGetterCallback(v8::Local<v8::String>, const v8::
 static void testObjAttrAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setTestObjAttr(WTF::getPtr(cppValue));
 }
 
@@ -600,7 +600,7 @@ static void
XMLObjAttrAttributeGetterCallback(v8::Local<v8::String>, const v8::P
 static void XMLObjAttrAttributeSetter(v8::Local<v8::Value> jsValue, const
v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setXMLObjAttr(WTF::getPtr(cppValue));
 }
 
@@ -1576,7 +1576,7 @@ static void
withExecutionContextAttributeAttributeGetterCallback(v8::Local<v8::S
 static void withExecutionContextAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     ExecutionContext* scriptContext =
currentExecutionContext(info.GetIsolate());
     imp->setWithExecutionContextAttribute(scriptContext,
WTF::getPtr(cppValue));
 }
@@ -1604,7 +1604,7 @@ static void
withActiveWindowAndFirstWindowAttributeAttributeGetterCallback(v8::L
 static void
withActiveWindowAndFirstWindowAttributeAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
    
imp->setWithActiveWindowAndFirstWindowAttribute(activeDOMWindow(info.GetIsolate()),
firstDOMWindow(info.GetIsolate()), WTF::getPtr(cppValue));
 }
 
@@ -1635,7 +1635,7 @@ static void
withScriptStateAttributeRaisesAttributeGetterCallback(v8::Local<v8::
 static void withScriptStateAttributeRaisesAttributeSetter(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setWithScriptStateAttributeRaises(WTF::getPtr(cppValue));
 }
 
@@ -2497,7 +2497,7 @@ static void
perWorldAttributeAttributeGetterCallback(v8::Local<v8::String>, cons
 static void perWorldAttributeAttributeSetter(v8::Local<v8::Value> jsValue,
const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setPerWorldAttribute(WTF::getPtr(cppValue));
 }
 
@@ -2524,7 +2524,7 @@ static void
perWorldAttributeAttributeGetterCallbackForMainWorld(v8::Local<v8::S
 static void perWorldAttributeAttributeSetterForMainWorld(v8::Local<v8::Value>
jsValue, const v8::PropertyCallbackInfo<void>& info)
 {
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, cppValue, V8TestObject::hasInstance(jsValue,
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(jsValue)) : 0);
+    V8TRYCATCH_VOID(TestObj*, cppValue,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), jsValue));
     imp->setPerWorldAttribute(WTF::getPtr(cppValue));
 }
 
@@ -3208,7 +3208,7 @@ static void voidMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>&
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     imp->voidMethodWithArgs(longArg, strArg, objArg);
 }
 
@@ -3243,7 +3243,7 @@ static void longMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>&
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     v8SetReturnValueInt(info, imp->longMethodWithArgs(longArg, strArg,
objArg));
 }
 
@@ -3279,7 +3279,7 @@ static void objMethodWithArgsMethod(const
v8::FunctionCallbackInfo<v8::Value>& i
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_EXCEPTION_VOID(int, longArg, toInt32(info[0], exceptionState),
exceptionState);
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[2],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[2]));
     v8SetReturnValue(info, imp->objMethodWithArgs(longArg, strArg, objArg));
 }
 
@@ -3361,7 +3361,7 @@ static void methodThatRequiresAllArgsAndThrowsMethod(const
v8::FunctionCallbackI
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[0]);
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[1],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[1])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[1]));
     RefPtr<TestObj> result = imp->methodThatRequiresAllArgsAndThrows(strArg,
objArg, exceptionState);
     if (exceptionState.throwIfNeeded())
         return;
@@ -4280,7 +4280,7 @@ static void overloadedMethod3Method(const
v8::FunctionCallbackInfo<v8::Value>& i
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     imp->overloadedMethod(objArg);
 }
 
@@ -4354,7 +4354,7 @@ static void overloadedMethodA1Method(const
v8::FunctionCallbackInfo<v8::Value>&
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     if (UNLIKELY(info.Length() <= 1)) {
         imp->overloadedMethodA(objArg);
         return;
@@ -4370,7 +4370,7 @@ static void overloadedMethodA2Method(const
v8::FunctionCallbackInfo<v8::Value>&
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(TestObj*, objArg, V8TestObject::hasInstance(info[0],
info.GetIsolate()) ?
V8TestObject::toNative(v8::Handle<v8::Object>::Cast(info[0])) : 0);
+    V8TRYCATCH_VOID(TestObj*, objArg,
V8TestObject::toNativeWithTypeCheck(info.GetIsolate(), info[0]));
     V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, strArg, info[1]);
     imp->overloadedMethodA(objArg, strArg);
 }
@@ -4658,7 +4658,7 @@ static void domStringListFunctionMethod(const
v8::FunctionCallbackInfo<v8::Value
         return;
     }
     TestObj* imp = V8TestObject::toNative(info.Holder());
-    V8TRYCATCH_VOID(DOMStringList*, values,
V8DOMStringList::hasInstance(info[0], info.GetIsolate()) ? V8DOMStringLi…
(message too large)

[haraken, 2014-02-20 10:42:50]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-02-20 10:43:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haraken@chromium.org/171533006/3

[commit-bot: I haz the power, 2014-02-20 14:09:21]

Change committed as 167512

[haraken, 2014-02-21 00:47:44]

LGTM

I'm a bit concerned that this CL might cause memory leaks since it is
introducing a lot of persistent handles to the CSSRule hierarchy.

That being said:

- I'm getting to understand that it isn't realistic to try hard to guarantee
that each incremental oilpan change doesn't cause memory leaks.

- Even if each incremental oilpan change causes leaks, those leaks will be fixed
as we move more things to oilpan and remove persistent handles. If all leaks are
fixed by the time the oilpan flag is enabled, there will be no issue.

Therefore I'm OK with having persistent handles in each incremental oilpan
change even if it causes unexpected memory leaks (unless the leak is a serious
one).

[haraken, 2014-02-21 00:48:30]

^^^ Sorry, ignore this comment. I posted the comment to a wrong issue.