Source/bindings/tests/results/V8TestInterfaceConstructor.cpp - Issue 171533006: V8 Binding: Introduce toNativeWithTypeCheck

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

Issue 171533006: V8 Binding: Introduce toNativeWithTypeCheck (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « Source/bindings/tests/results/V8TestInterfaceConstructor.h ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor2.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

index 5a6a83f6653b1538c3bdb39cbd4437174c514b1f..5140619368f8ea1ee05b252ffa124b01e82f261f 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor.cpp

@@ -93,7 +93,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

ExceptionState exceptionState(ExceptionState::ConstructionContext, "TestInterfaceConstructor", info.Holder(), info.GetIsolate());

V8TRYCATCH_VOID(double, doubleArg, static_cast<double>(info[0]->NumberValue()));

V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, stringArg, info[1]);

- V8TRYCATCH_VOID(TestInterfaceEmpty*, testInterfaceEmptyArg, V8TestInterfaceEmpty::hasInstance(info[2], info.GetIsolate()) ? V8TestInterfaceEmpty::toNative(v8::Handle<v8::Object>::Cast(info[2])) : 0);

+ V8TRYCATCH_VOID(TestInterfaceEmpty*, testInterfaceEmptyArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[2]));

V8TRYCATCH_VOID(Dictionary, dictionaryArg, Dictionary(info[3], info.GetIsolate()));

if (!dictionaryArg.isUndefinedOrNull() && !dictionaryArg.isObject()) {

exceptionState.throwTypeError("parameter 4 ('dictionaryArg') is not an object.");

@@ -107,7 +107,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

exceptionState.throwIfNeeded();

return;

}

- V8TRYCATCH_VOID(TestInterfaceEmpty*, optionalTestInterfaceEmptyArg, V8TestInterfaceEmpty::hasInstance(info[6], info.GetIsolate()) ? V8TestInterfaceEmpty::toNative(v8::Handle<v8::Object>::Cast(info[6])) : 0);

+ V8TRYCATCH_VOID(TestInterfaceEmpty*, optionalTestInterfaceEmptyArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[6]));

ExecutionContext* context = currentExecutionContext(info.GetIsolate());

Document& document = *toDocument(currentExecutionContext(info.GetIsolate()));

RefPtr<TestInterfaceConstructor> impl = TestInterfaceConstructor::create(context, document, doubleArg, stringArg, testInterfaceEmptyArg, dictionaryArg, sequenceStringArg, optionalDictionaryArg, optionalTestInterfaceEmptyArg, exceptionState);

@@ -191,6 +191,11 @@ bool V8TestInterfaceConstructor::hasInstance(v8::Handle<v8::Value> jsValue, v8::

|| V8PerIsolateData::from(isolate)->hasInstanceInNonMainWorld(&wrapperTypeInfo, jsValue);

}

+TestInterfaceConstructor* V8TestInterfaceConstructor::toNativeWithTypeCheck(v8::Isolate* isolate, v8::Handle<v8::Value> value)

+ return hasInstance(value, isolate) ? fromInternalPointer(v8::Handle<v8::Object>::Cast(value)->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex)) : 0;

v8::Handle<v8::Object> V8TestInterfaceConstructor::createWrapper(PassRefPtr<TestInterfaceConstructor> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

{

ASSERT(impl);