third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc023-markup.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html

index b72d7d73310f057fdbdd2dc06775f87c1aea42af..53bce1e300bdb49d3086a540d1ea34ec9ae978ff 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc024-timestamp.html

@@ -4,11 +4,13 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

- <script>

+ <script>

var numberOfTrackTests = 2;

function trackLoaded()

{

numberOfTracksLoaded++;

@@ -17,28 +19,28 @@

testTrackError(1);

}

function testTrack(i)

{

findMediaElement();

testExpected("video.textTracks[" + i + "].cues.length", "3");

// Note: Timestamps are handled as ProcessingInstructions, but because ProcessingInstructions

// are used in XML and not HTML, they are ignored here.

// This should later be tested with oncuechange events.

var fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("This cue is painted on."));

testExpected("video.textTracks[" + i + "].cues[0].getCueAsHTML().textContent", fragment.textContent);

fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("I said Bear is coming!!!!"));

testExpected("video.textTracks[" + i + "].cues[1].getCueAsHTML().textContent", fragment.textContent);

fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("I said Bear is coming now!!!!"));

testExpected("video.textTracks[" + i + "].cues[2].getCueAsHTML().textContent", fragment.textContent);

allTestsEnded();

@@ -48,31 +50,31 @@

{

findMediaElement();

testExpected("video.textTracks[" + i + "].cues.length", "3");

var fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("This cue is painted on.\nBut since the last two timestamps are out of order, they are ignored."));

testExpected("video.textTracks[" + i + "].cues[0].getCueAsHTML().textContent", fragment.textContent);

fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("I said Bear is coming!!!!\nAll of these timestamps are before the start of the cue, so get ignored."));

testExpected("video.textTracks[" + i + "].cues[1].getCueAsHTML().textContent", fragment.textContent);

fragment = document.createDocumentFragment();

fragment.appendChild(document.createTextNode("I said Bear is coming now!!!!\nAll of these timestamps are after the end of the cue, so get ignored."));

testExpected("video.textTracks[" + i + "].cues[2].getCueAsHTML().textContent", fragment.textContent);

allTestsEnded();

}

</script>

</head>

<p>Tests cues with <timestamps> tags.</p>

- <video>

+ <video>

- <track src="captions-webvtt/tc024-timestamp-bad.vtt" onload="trackLoaded()">

+ <track src="captions-webvtt/tc024-timestamp-bad.vtt" onload="trackLoaded()">

</video>

</body>

-</html>

+</html>