Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html
index 520b46ae9aec4eb841aed45b14b0ba224ed48103..f04db0ae520f9e7803c9da8e420a690f7cf31831 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc025-class-markup.html
@@ -4,11 +4,13 @@
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<script src=../media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=../video-test.js></script>
- <script>
+ <script>
var numberOfTrackTests = 2;
-
+
function trackLoaded()
{
numberOfTracksLoaded++;
@@ -17,26 +19,26 @@
testTrackError(1);
}
}
-
+
function testTrack(i)
{
findMediaElement();
testExpected("video.textTracks[" + i + "].cues.length", "3");
-
+
var fragment = document.createDocumentFragment();
var cspan = document.createElement("span");
cspan.className = "black";
cspan.appendChild(document.createTextNode("Bear is Coming!!!!!"));
fragment.appendChild(cspan);
-
+
testExpected(fragment.isEqualNode(video.textTracks[i].cues[0].getCueAsHTML()), true);
-
+
fragment = document.createDocumentFragment();
cspan = document.createElement("span");
cspan.className = "green";
cspan.appendChild(document.createTextNode("I said Bear is coming!!!!"));
fragment.appendChild(cspan);
-
+
testExpected(fragment.isEqualNode(video.textTracks[i].cues[1].getCueAsHTML()), true);
fragment = document.createDocumentFragment();
@@ -46,7 +48,7 @@
cspan.appendChild(document.createTextNode("Bear is coming now"));
fragment.appendChild(cspan);
fragment.appendChild(document.createTextNode("!!!!"));
-
+
testExpected(fragment.isEqualNode(video.textTracks[i].cues[2].getCueAsHTML()), true);
allTestsEnded();
@@ -56,7 +58,7 @@
{
findMediaElement();
testExpected("video.textTracks[" + i + "].cues.length", "3");
-
+
var fragment = document.createDocumentFragment();
var cspan = document.createElement("span");
cspan.appendChild(document.createTextNode("Bear is Coming!!!!!"));
@@ -64,7 +66,7 @@
fragment.appendChild(document.createTextNode("\nThe space signified an annotation start."));
testExpected(fragment.isEqualNode(video.textTracks[i].cues[0].getCueAsHTML()), true);
-
+
fragment = document.createDocumentFragment();
cspan = document.createElement("span");
cspan.className = "red&large";
@@ -90,9 +92,9 @@
</head>
<body onload="enableAllTextTracks()">
<p>Tests cues with class markup &lt;c&gt;.</p>
- <video>
+ <video>
<track src="captions-webvtt/tc025-class.vtt" onload="trackLoaded()">
<track src="captions-webvtt/tc025-class-bad.vtt" onload="trackLoaded()">
</video>
</body>
-</html>
+</html>

Powered by Google App Engine
This is Rietveld 408576698