Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html
index 20d10c1a3c94f8503dfa095f3059c30926b8fae3..902f39e15d18f5fcf7900544bf55e8b4132b4c7e 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html
@@ -4,11 +4,13 @@
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<script src=../media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=../video-test.js></script>
- <script>
+ <script>
var numberOfTrackTests = 2;
-
+
function trackLoaded()
{
numberOfTracksLoaded++;
@@ -18,11 +20,11 @@
}
}
-
+
function testTrack(i)
{
findMediaElement();
- var expected =
+ var expected =
{
length : 7,
tests:
@@ -40,14 +42,14 @@
],
};
testCues(i, expected);
-
+
allTestsEnded();
}
function testTrackError(i)
{
findMediaElement();
- var expected =
+ var expected =
{
length : 2,
tests:
@@ -60,14 +62,14 @@
],
};
testCues(i, expected);
-
+
allTestsEnded();
}
</script>
</head>
<body onload="enableAllTextTracks()">
<p>Tests entities in the cue text.</p>
- <video>
+ <video>
<track src="captions-webvtt/tc022-entities.vtt" onload="trackLoaded()">
<track src="captions-webvtt/tc022-entities-wrong.vtt" onload="trackLoaded()">
</video>

Powered by Google App Engine
This is Rietveld 408576698