third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-webvtt-tc020-cue-size-align.html ('k') | third_party/WebKit/LayoutTests/media/track/track-webvtt-tc022-entities.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html

index c9634c05b96bea74f4f5ffd8154d30ba5db085eb..926df2e51eb9b54480e7f55b340e08a20334deab 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-webvtt-tc021-valign.html

@@ -4,11 +4,13 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

- <script>

+ <script>

var numberOfTrackTests = 3;

function trackLoaded()

{

numberOfTracksLoaded++;

@@ -22,7 +24,7 @@

function testTrack(i)

{

findMediaElement();

- var expected =

+ var expected =

{

length : 3,

tests:

@@ -42,14 +44,14 @@

};

testCues(i, expected);

allTestsEnded();

}

function testTrackError(i)

{

findMediaElement();

- var expected =

+ var expected =

{

length : 3,

tests:

@@ -61,14 +63,14 @@

};

testCues(i, expected);

allTestsEnded();

}

</script>

</head>

<p>Tests cue vertical alignment (direction) from settings.</p>

- <video>

+ <video>