third_party/WebKit/LayoutTests/media/controls-cast-button.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/controls-cast-button.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/constructors.html ('k') | third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/controls-cast-button.html

diff --git a/third_party/WebKit/LayoutTests/media/controls-cast-button.html b/third_party/WebKit/LayoutTests/media/controls-cast-button.html

index 68e3c34ee0255328e67656eff41695f472d3ea3c..70ccec47287f163904920de3b8290c78442e7460 100644

--- a/third_party/WebKit/LayoutTests/media/controls-cast-button.html

+++ b/third_party/WebKit/LayoutTests/media/controls-cast-button.html

@@ -6,6 +6,8 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

</head>

<body>

@@ -41,7 +43,7 @@

var y = buttonBoundingRect.top + buttonBoundingRect.height / 2;

return new Array(x, y);

}

- async_test(function(t)

+ async_test(function(t)

{

findMediaElement();

video.src = findMediaFile("video", "content/test");

@@ -60,8 +62,8 @@

assert_not_equals(dimensions[0], 0, "button should exist");

assert_not_equals(dimensions[1], 0, "button should exist");

- // Check its position is to the right of the timeline

- // (can't test against volume control or closed caption button, since these don't always exist)

+ // Check its position is to the right of the timeline

+ // (can't test against volume control or closed caption button, since these don't always exist)

position = castButtonCoordinates(video);

timelinePosition = mediaControlsButtonCoordinates(video, "timeline");

assert_greater_than(position[0], timelinePosition[0], "button should be to right of timeline");