third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-button.html ('k') | third_party/WebKit/LayoutTests/media/controls-cast-do-not-fade-out.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

diff --git a/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html b/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

index e5a2a912969b215f1a8583eff5bf20a909e87843..7648af202dca91406082145e8ddd534223eedd31 100644

--- a/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

+++ b/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html

@@ -6,6 +6,8 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

</head>

<body>

@@ -41,7 +43,7 @@

var y = buttonBoundingRect.top + buttonBoundingRect.height / 2;

return new Array(x, y);

}

- async_test(function(t)

+ async_test(function(t)

{

findMediaElement();

video.src = findMediaFile("video", "content/test");

@@ -53,7 +55,7 @@

// Video should not have a cast button since the video is too narrow

button = castButton(video);

assert_equals(button.style.display, "none", "button should not be visible with no cast devices");

// It should, however, have an overlay cast button instead

button = overlayCastButton(video);

rect = button.getBoundingClientRect();

@@ -68,4 +70,4 @@

});

</script>

</body>

-</html>

+</html>