Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 17153009: Add Large Tests bots for WebRTC (Closed)

Created:
7 years, 6 months ago by kjellander_chromium
Modified:
7 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Add Large Tests bots for WebRTC Several of WebRTC's tests requires bare-metal hardware so real audio devices are present. This CL adds such tests that use audio and video devices. Some of the tests also measure perf numbers, which is why the test adding method in chromium_commands.py was refactored. This also paved road ahead of adding TSan RV and DrMemory bots, which is on our roadmap ahead. TEST=local builds. BUG=252195 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=212915

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased #

Patch Set 3 : Restored rebooting only for Win machines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -15 lines) Patch
M masters/master.client.webrtc/master_linux_cfg.py View 1 6 chunks +34 lines, -2 lines 0 comments Download
M masters/master.client.webrtc/master_mac_cfg.py View 1 2 chunks +22 lines, -1 line 0 comments Download
M masters/master.client.webrtc/master_win_cfg.py View 1 2 chunks +23 lines, -0 lines 0 comments Download
M masters/master.client.webrtc/slaves.cfg View 3 chunks +36 lines, -0 lines 0 comments Download
M masters/master.tryserver.webrtc/master.cfg View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M scripts/master/factory/webrtc_factory.py View 1 1 chunk +1 line, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kjellander_chromium
7 years, 6 months ago (2013-06-20 12:29:32 UTC) #1
iannucci
Sorry for the delay, lgtm https://codereview.chromium.org/17153009/diff/1/scripts/master/factory/chromium_commands.py File scripts/master/factory/chromium_commands.py (right): https://codereview.chromium.org/17153009/diff/1/scripts/master/factory/chromium_commands.py#newcode1030 scripts/master/factory/chromium_commands.py:1030: def AddWebRTCTests(self, tests, factory_properties, ...
7 years, 6 months ago (2013-06-25 05:32:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kjellander@chromium.org/17153009/35001
7 years, 5 months ago (2013-07-22 18:06:31 UTC) #3
commit-bot: I haz the power
7 years, 5 months ago (2013-07-22 18:07:44 UTC) #4
Message was sent while issue was closed.
Change committed as 212915

Powered by Google App Engine
This is Rietveld 408576698