Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1715263002: [crankshaft][X87] Fix Math.min(-0, -0) (Closed)

Created:
4 years, 10 months ago by zhengxing.li
Modified:
4 years, 10 months ago
Reviewers:
Weiliang, chunyang.dai
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft][X87] Fix Math.min(-0, -0) The CL #33996 (https://codereview.chromium.org/1695283002) exposed one hidden bug in x87 crankshaft code generation for LCodeGen::DoMathMinMax(). This CL fixed this bug. BUG= Committed: https://crrev.com/ebb0f57e9af8894e0673fde5d4c70cb0be49bdd6 Cr-Commit-Position: refs/heads/master@{#34183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 10 months ago (2016-02-22 02:08:38 UTC) #2
Weiliang
lgtm
4 years, 10 months ago (2016-02-22 02:50:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715263002/1
4 years, 10 months ago (2016-02-22 02:52:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-22 03:41:54 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 03:43:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebb0f57e9af8894e0673fde5d4c70cb0be49bdd6
Cr-Commit-Position: refs/heads/master@{#34183}

Powered by Google App Engine
This is Rietveld 408576698