[crankshaft][arm][mips] Fix Math.min(0, 0)

[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.

Committed: https://crrev.com/0d59772b2b5c0517b925193bf0fa3fca6c9dd62b
Cr-Commit-Position: refs/heads/master@{#33996}

[Jakob Kummerow, 2016-02-15 14:17:24]

Description was changed from

==========
[crankshaft][arm][mips] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.
==========

to

==========
[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.
==========

[Jakob Kummerow, 2016-02-15 14:21:46]

jkummerow@chromium.org changed reviewers:
+ yangguo@chromium.org

[Jakob Kummerow, 2016-02-15 14:21:47]

Yang: as discussed, PTAL.

MIPS folks: FYI. I noticed that there are max_d/min_d instructions in
assembler-mips{,64}.h. If those do what their name suggests, then the
MIPS/MIPS64 implementations of the representation.IsDouble() branch of
LCodeGen::DoMathMinMax could be as simple as it is on arm64. I'm leaving this up
to you to improve in a follow-up CL if you want. (Crankshaft is deprecated so
it's not worth putting a whole lot of effort into.)

[Yang, 2016-02-15 14:23:07]

On 2016/02/15 14:21:47, Jakob wrote:
> Yang: as discussed, PTAL.
> 
> MIPS folks: FYI. I noticed that there are max_d/min_d instructions in
> assembler-mips{,64}.h. If those do what their name suggests, then the
> MIPS/MIPS64 implementations of the representation.IsDouble() branch of
> LCodeGen::DoMathMinMax could be as simple as it is on arm64. I'm leaving this
up
> to you to improve in a follow-up CL if you want. (Crankshaft is deprecated so
> it's not worth putting a whole lot of effort into.)

lgtm.

[Jakob Kummerow, 2016-02-15 14:23:33]

The CQ bit was checked by jkummerow@chromium.org

[commit-bot: I haz the power, 2016-02-15 14:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1695283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1695283002/20001

[commit-bot: I haz the power, 2016-02-15 14:42:41]

Description was changed from

==========
[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.
==========

to

==========
[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.
==========

[commit-bot: I haz the power, 2016-02-15 14:42:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-15 14:43:08]

Description was changed from

==========
[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.
==========

to

==========
[crankshaft][arm][mips][mips64] Fix Math.min(0, 0)

for the special case where the same register is used as both left and
right input.

Committed: https://crrev.com/0d59772b2b5c0517b925193bf0fa3fca6c9dd62b
Cr-Commit-Position: refs/heads/master@{#33996}
==========

[commit-bot: I haz the power, 2016-02-15 14:43:09]

Patchset 2 (id:??) landed as
https://crrev.com/0d59772b2b5c0517b925193bf0fa3fca6c9dd62b
Cr-Commit-Position: refs/heads/master@{#33996}

[balazs.kilvady, 2016-02-18 18:29:59]

On 2016/02/15 14:21:47, Jakob wrote:
> Yang: as discussed, PTAL.
> 
> MIPS folks: FYI. I noticed that there are max_d/min_d instructions in
> assembler-mips{,64}.h. If those do what their name suggests, then the
> MIPS/MIPS64 implementations of the representation.IsDouble() branch of
> LCodeGen::DoMathMinMax could be as simple as it is on arm64. I'm leaving this
up
> to you to improve in a follow-up CL if you want. (Crankshaft is deprecated so
> it's not worth putting a whole lot of effort into.)

Thank you for the info, we will check the possibilities. Although min_d, max_d
are MIPSr6 instructions and my MacroAssembler CL to use min/max macros on all
MIPS platforms is not landed yet. https://codereview.chromium.org/1694833002/

[balazs.kilvady, 2016-02-18 18:30:01]

On 2016/02/15 14:21:47, Jakob wrote:
> Yang: as discussed, PTAL.
> 
> MIPS folks: FYI. I noticed that there are max_d/min_d instructions in
> assembler-mips{,64}.h. If those do what their name suggests, then the
> MIPS/MIPS64 implementations of the representation.IsDouble() branch of
> LCodeGen::DoMathMinMax could be as simple as it is on arm64. I'm leaving this
up
> to you to improve in a follow-up CL if you want. (Crankshaft is deprecated so
> it's not worth putting a whole lot of effort into.)

Thank you for the info, we will check the possibilities. Although min_d, max_d
are MIPSr6 instructions and my MacroAssembler CL to use min/max macros on all
MIPS platforms is not landed yet. https://codereview.chromium.org/1694833002/