Stop using the old-style profile names when using --new-profile-management

chrome/browser/profiles/profiles_state.h

Index: chrome/browser/profiles/profiles_state.h
diff --git a/chrome/browser/profiles/profiles_state.h b/chrome/browser/profiles/profiles_state.h
index 85370f2c7be326ac73a33af91c3e39dc50c29b80..995ee5d5a17bde65456df6706b67a1ad220a3bf4 100644
--- a/chrome/browser/profiles/profiles_state.h
+++ b/chrome/browser/profiles/profiles_state.h
@@ -25,8 +25,11 @@ base::FilePath GetDefaultProfileDir(const base::FilePath& user_data_dir);
 // Register multi-profile related preferences in Local State.
 void RegisterPrefs(PrefRegistrySimple* registry);
 
-// Returns the display name of the active on-the-record profile (or guest).
-base::string16 GetActiveProfileDisplayName(Browser* browser);
+// Returns the display name of the active on-the-record profile (or guest)
+// used in the avatar button. If there is only one local profile present, it
+// will return IDS_SINGLE_PROFILE_DISPLAY_NAME, unless the profile has a
+// user entered custom name.
+base::string16 GetAvatarButtonDisplayNameForProfile(Profile* profile);

[groby-ooo-7-16, 2014/02/20 20:17:27]

GetProfileAvatarName?

I'm bikeshedding probably, but I really don't like having UI element types in
the function name. And based on the old naming - Get ActiveProfile DisplayName -
it seems Get Profile AvatarName. I.e. verb, object, noun. 

Feel free to ignore :)

[rpetterson, 2014/02/20 21:41:32]

I agree with groby on this one. I think GetAvatarNameForProfile would be better.

[noms (inactive), 2014/02/24 22:35:06]

Hmm, doesn't avatar name imply "the name of the avatar we are displaying"? Let's
go with it for now though, and see if it causes confusion in the future.

On 2014/02/20 21:41:32, rpetterson wrote:

 
 // Update the name of |profile| to |new_profile_name|. This updates the
 // profile preferences, which triggers an update in the ProfileInfoCache.