Stop using the old-style profile names when using --new-profile-management

chrome/browser/profiles/profiles_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILES_STATE_H_
 #define CHROME_BROWSER_PROFILES_PROFILES_STATE_H_
 
 #include <vector>
 #include "base/strings/string16.h"
 
 class Browser;
 class PrefRegistrySimple;
 class Profile;
 namespace base { class FilePath; }
 
 namespace profiles {
 
 // Checks if multiple profiles is enabled.
 bool IsMultipleProfilesEnabled();
 
 // Returns the path to the default profile directory, based on the given
 // user data directory.
 base::FilePath GetDefaultProfileDir(const base::FilePath& user_data_dir);
 
 // Register multi-profile related preferences in Local State.
 void RegisterPrefs(PrefRegistrySimple* registry);
 
-// Returns the display name of the active on-the-record profile (or guest).
-base::string16 GetActiveProfileDisplayName(Browser* browser);
+// Returns the display name of the active on-the-record profile (or guest)
+// used in the avatar button. If there is only one local profile present, it
+// will return IDS_SINGLE_PROFILE_DISPLAY_NAME, unless the profile has a
+// user entered custom name.
+base::string16 GetAvatarButtonDisplayNameForProfile(Profile* profile);

[groby-ooo-7-16, 2014/02/20 20:17:27]

GetProfileAvatarName?

I'm bikeshedding probably, but I really don't like having UI element types in
the function name. And based on the old naming - Get ActiveProfile DisplayName -
it seems Get Profile AvatarName. I.e. verb, object, noun. 

Feel free to ignore :)

[rpetterson, 2014/02/20 21:41:32]

I agree with groby on this one. I think GetAvatarNameForProfile would be better.

[noms (inactive), 2014/02/24 22:35:06]

Hmm, doesn't avatar name imply "the name of the avatar we are displaying"? Let's
go with it for now though, and see if it causes confusion in the future.

On 2014/02/20 21:41:32, rpetterson wrote:

 
 // Update the name of |profile| to |new_profile_name|. This updates the
 // profile preferences, which triggers an update in the ProfileInfoCache.
 void UpdateProfileName(Profile* profile,
                        const base::string16& new_profile_name);
 
 // Returns the list of secondary accounts for a specific |profile|, which is
 // all the email addresses associated with the profile that are not equal to
 // the |primary_account|.
 std::vector<std::string> GetSecondaryAccountsForProfile(
     Profile* profile,
     const std::string& primary_account);
 
 // Returns whether the |browser|'s profile is a non-incognito or guest profile.
 // The distinction is needed because guest profiles are implemented as
 // incognito profiles.
 bool IsRegularOrGuestSession(Browser* browser);
 
 }  // namespace profiles
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILES_STATE_H_