Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171513010: Move the "import find_depot_tools" line to sections that actually use it. (Closed)

Created:
6 years, 10 months ago by saiarcot895
Modified:
6 years, 10 months ago
Reviewers:
Nico, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move the "import find_depot_tools" line to sections that actually use it. This shrinks the dependency of depot_tools to only Windows and Cygwin, and allows those on other OSes to just build tarballs of sources without also having the depot_tools. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252434

Patch Set 1 #

Patch Set 2 : Add self to AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/gyp_chromium View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Paweł Hajdan Jr.
Thanks, the patch looks good. Please just add yourself to AUTHORS file. I've verified we ...
6 years, 10 months ago (2014-02-20 04:25:51 UTC) #1
saiarcot895
Added to AUTHORS file.
6 years, 10 months ago (2014-02-20 04:42:05 UTC) #2
saiarcot895
The CQ bit was checked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:31 UTC) #3
saiarcot895
The CQ bit was unchecked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:31 UTC) #4
saiarcot895
The CQ bit was checked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:32 UTC) #5
saiarcot895
The CQ bit was unchecked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:51 UTC) #6
saiarcot895
The CQ bit was checked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:51 UTC) #7
saiarcot895
The CQ bit was unchecked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 04:43:56 UTC) #8
Nico
lgtm
6 years, 10 months ago (2014-02-20 08:06:09 UTC) #9
Paweł Hajdan Jr.
LGTM
6 years, 10 months ago (2014-02-20 18:21:27 UTC) #10
saiarcot895
The CQ bit was checked by saiarcot895@gmail.com
6 years, 10 months ago (2014-02-20 19:44:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saiarcot895@gmail.com/171513010/40001
6 years, 10 months ago (2014-02-20 19:48:54 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 00:30:31 UTC) #13
Message was sent while issue was closed. 
Change committed as 252434

Powered by Google App Engine
This is Rietveld 408576698