Chromium Code Reviews Chromium Code Reviews
Issue
171513004:
[GCM] Adding a list of accounts present on the client to checkin request (Closed)
Description[GCM] Adding a list of accounts present on the client to checkin request
We need to bind device id (profile specific) to accounts running in that
profile. For that reason we are grabbing all of the accounts as tracked
by the ProfileOAuth2TokenService and pass them to Initialize method of
GCMClientImpl. The list of accounts is then passed to CheckinRequest when
the request is happening.
Once the CheckinRequest is done more often than simply on login, we may want
to give a more updated list of accounts than the one present on startup of
Chromium. For now there is no reason to handle that case.
BUG=343203
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252759
Patch Set 1 #
Total comments: 6
Patch Set 2 : Updates based on CR, updating formatting #Patch Set 3 : Adding documentation of the parameter of GCMClient.Initialize(...account_ids...) #
Total comments: 2
Patch Set 4 : adding const keyword to checkin request fields #Patch Set 5 : Fixing compilation issue with GCMClientMock #Patch Set 6 : Fix to android test issue #Messages
Total messages: 29 (0 generated)
|
