[GCM] Adding a list of accounts present on the client to checkin request

google_apis/gcm/engine/checkin_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gcm/engine/checkin_request.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "google_apis/gcm/protocol/checkin.pb.h"
@@ skipping 34 matching lines @@
 }
 
 }  // namespace
 
 CheckinRequest::CheckinRequest(
     const CheckinRequestCallback& callback,
     const net::BackoffEntry::Policy& backoff_policy,
     const checkin_proto::ChromeBuildProto& chrome_build_proto,
     uint64 android_id,
     uint64 security_token,
+    const std::vector<std::string>& account_ids,
     net::URLRequestContextGetter* request_context_getter)
     : request_context_getter_(request_context_getter),
       callback_(callback),
       backoff_entry_(&backoff_policy),
       chrome_build_proto_(chrome_build_proto),
       android_id_(android_id),
       security_token_(security_token),
+      account_ids_(account_ids),
       weak_ptr_factory_(this) {
 }
 
 CheckinRequest::~CheckinRequest() {}
 
 void CheckinRequest::Start() {
   DCHECK(!url_fetcher_.get());
 
   checkin_proto::AndroidCheckinRequest request;
   request.set_id(android_id_);
   request.set_security_token(security_token_);
   request.set_user_serial_number(kDefaultUserSerialNumber);
   request.set_version(kRequestVersionValue);
 
   checkin_proto::AndroidCheckinProto* checkin = request.mutable_checkin();
   checkin->mutable_chrome_build()->CopyFrom(chrome_build_proto_);
 #if defined(CHROME_OS)
   checkin->set_type(checkin_proto::DEVICE_CHROME_OS);
 #else
   checkin->set_type(checkin_proto::DEVICE_CHROME_BROWSER);
 #endif
 
+  for (std::vector<std::string>::iterator iter = account_ids_.begin();

[jianli, 2014/02/19 01:18:12]

nit: const_iterator

[fgorski, 2014/02/19 19:00:25]

Done.

+       iter != account_ids_.end(); ++iter) {
+    std::string* account_cookie = request.add_account_cookie();
+    *account_cookie = "[" + *iter + "]";

[jianli, 2014/02/19 01:18:12]

Why not just:
  request.add_account_cookie("[" + *iter + "]");

By the way, why do we need to add square brackets? Any doc on this?

[fgorski, 2014/02/19 19:00:25]

Done. Couldn't find documentation for it.

+  }
+
   std::string upload_data;
   CHECK(request.SerializeToString(&upload_data));
 
   url_fetcher_.reset(
       net::URLFetcher::Create(GURL(kCheckinURL), net::URLFetcher::POST, this));
   url_fetcher_->SetRequestContext(request_context_getter_);
   url_fetcher_->SetUploadData(kRequestContentType, upload_data);
   url_fetcher_->Start();
 }
 
@@ skipping 62 matching lines @@
     RecordCheckinStatusToUMA(ZERO_ID_OR_TOKEN);
     RetryWithBackoff(true);
     return;
   }
 
   RecordCheckinStatusToUMA(SUCCESS);
   callback_.Run(response_proto.android_id(), response_proto.security_token());
 }
 
 }  // namespace gcm