Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1715063002:
Simplify calculations in AADistanceFieldPathBatch::writePathVertices. (Closed)
DescriptionSimplify calculations in AADistanceFieldPathBatch::writePathVertices.
No API changes.
BUG=skia:4632
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1715063002
TBR=reed
Committed: https://skia.googlesource.com/skia/+/01e583807618038a578a3b07cfad3101d24115c7
Patch Set 1 : #
Messages
Total messages: 41 (24 generated)
Description was changed from ========== WIP BUG=skia: ========== to ========== WIP BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/40001
Description was changed from ========== WIP BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:60001) has been deleted
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
benjaminwagner@google.com changed reviewers: + joshualitt@google.com
Description was changed from ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
joshualitt@google.com changed reviewers: + jvanverth@google.com
Adding Jim
lgtm
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)
Description was changed from ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. No API changes. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... TBR=reed ==========
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715063002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715063002/80001
Message was sent while issue was closed.
Description was changed from ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. No API changes. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... TBR=reed ========== to ========== Simplify calculations in AADistanceFieldPathBatch::writePathVertices. No API changes. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... TBR=reed Committed: https://skia.googlesource.com/skia/+/01e583807618038a578a3b07cfad3101d24115c7 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:80001) as https://skia.googlesource.com/skia/+/01e583807618038a578a3b07cfad3101d24115c7 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
