Return undefined from RegExp.prototype.compile

Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cdec6d2bc51a1c60f1405b7c797c050175b5202b
Cr-Commit-Position: refs/heads/master@{#34172}

[adamk, 2016-02-19 23:05:05]

Description was changed from

==========
Return undefined from RegExp.prototype.compile

This was changed to match Firefox in
https://chromium.googlesource.com/v8/v8/+/469d9bfa,
but website breakage was seen in M49 Beta. Given that RegExp.prototype.compile
is
non-standard, it seems reasonable to revert to the old behavior for the sake
of avoiding regressions on the web (JSC continues to return undefined).

BUG=chromium:585775
LOG=y
==========

to

==========
Return undefined from RegExp.prototype.compile

This was changed to match Firefox in
https://chromium.googlesource.com/v8/v8/+/469d9bfa,
but website breakage was seen in M49 Beta. Given that RegExp.prototype.compile
is
non-standard, it seems reasonable to revert to the old behavior for the sake
of avoiding regressions on the web (JSC continues to return undefined).

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[adamk, 2016-02-19 23:05:27]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org, yangguo@chromium.org

[adamk, 2016-02-19 23:09:10]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 23:09:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903004/1

[Dan Ehrenberg, 2016-02-19 23:16:01]

lgtm

RegExp.prototype.compile is not non-standard; it is specified in Annex B
https://tc39.github.io/ecma262/#sec-regexp.prototype.compile . I agree with this
change from a web compat perspective, but we should figure out how to make this
work similarly across browsers and standardize whatever the eventual result is.
Does the affected website work on Firefox?

[adamk, 2016-02-19 23:18:30]

On 2016/02/19 23:16:01, Dan Ehrenberg wrote:
> lgtm
> 
> RegExp.prototype.compile is not non-standard; it is specified in Annex B
> https://tc39.github.io/ecma262/#sec-regexp.prototype.compile . I agree with
this
> change from a web compat perspective, but we should figure out how to make
this
> work similarly across browsers and standardize whatever the eventual result
is.
> Does the affected website work on Firefox?

I swear I searched for it in the spec, must have searched before the whole thing
loaded. Will update the CL description.

Re: Firefox, see the bug for details, but no, it exhibits the same bug in
Firefox.

[adamk, 2016-02-19 23:19:38]

Description was changed from

==========
Return undefined from RegExp.prototype.compile

This was changed to match Firefox in
https://chromium.googlesource.com/v8/v8/+/469d9bfa,
but website breakage was seen in M49 Beta. Given that RegExp.prototype.compile
is
non-standard, it seems reasonable to revert to the old behavior for the sake
of avoiding regressions on the web (JSC continues to return undefined).

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in 
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[Dan Ehrenberg, 2016-02-19 23:20:33]

On 2016/02/19 at 23:18:30, adamk wrote:
> On 2016/02/19 23:16:01, Dan Ehrenberg wrote:
> > lgtm
> > 
> > RegExp.prototype.compile is not non-standard; it is specified in Annex B
> > https://tc39.github.io/ecma262/#sec-regexp.prototype.compile . I agree with
this
> > change from a web compat perspective, but we should figure out how to make
this
> > work similarly across browsers and standardize whatever the eventual result
is.
> > Does the affected website work on Firefox?
> 
> I swear I searched for it in the spec, must have searched before the whole
thing loaded. Will update the CL description.
> 
> Re: Firefox, see the bug for details, but no, it exhibits the same bug in
Firefox.

OK, let's land this for now, but try to reach out to the website owner and
eventually revert.

[commit-bot: I haz the power, 2016-02-20 00:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-20 00:19:28]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-02-20 00:33:37]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-02-20 00:33:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714903004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714903004/1

[commit-bot: I haz the power, 2016-02-20 00:35:37]

Description was changed from

==========
Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in 
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in 
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-02-20 00:35:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-20 00:36:03]

Description was changed from

==========
Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in 
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
==========

to

==========
Return undefined from RegExp.prototype.compile

This was changed to match Annex B.2.5.1 of ES2015 and Firefox in
https://chromium.googlesource.com/v8/v8/+/469d9bfa, but website
breakage was seen in M49 Beta. JSC still returns undefined here.

BUG=chromium:585775
LOG=y
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/cdec6d2bc51a1c60f1405b7c797c050175b5202b
Cr-Commit-Position: refs/heads/master@{#34172}
==========

[commit-bot: I haz the power, 2016-02-20 00:36:04]

Patchset 1 (id:??) landed as
https://crrev.com/cdec6d2bc51a1c60f1405b7c797c050175b5202b
Cr-Commit-Position: refs/heads/master@{#34172}