Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: src/js/regexp.js

Issue 1714903004: Return undefined from RegExp.prototype.compile (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-585775.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/regexp.js
diff --git a/src/js/regexp.js b/src/js/regexp.js
index 0e9d3cb3d1d7333cb1cdfd822de7a27553d26889..d5e55ef3bcee3230d855e32eab9092e32a9c0d43 100644
--- a/src/js/regexp.js
+++ b/src/js/regexp.js
@@ -112,7 +112,10 @@ function RegExpCompileJS(pattern, flags) {
pattern = REGEXP_SOURCE(pattern);
}
- return RegExpInitialize(this, pattern, flags);
+ RegExpInitialize(this, pattern, flags);
+
+ // Return undefined for compatibility with JSC.
+ // See http://crbug.com/585775 for web compat details.
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-585775.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698