command_buffer_gles2: Implement EGL default Display as a global object

gpu/gles2_conform_support/egl/config.h

Index: gpu/gles2_conform_support/egl/config.h
diff --git a/gpu/gles2_conform_support/egl/config.h b/gpu/gles2_conform_support/egl/config.h
index 53bb56821812226be2f4e0c086e373a3f43f7c7f..a49f7f6210c344e6c5831c0ddc9f3ef909077c64 100644
--- a/gpu/gles2_conform_support/egl/config.h
+++ b/gpu/gles2_conform_support/egl/config.h
@@ -5,18 +5,18 @@
 #ifndef GPU_GLES2_CONFORM_TEST_CONFIG_H_
 #define GPU_GLES2_CONFORM_TEST_CONFIG_H_
 
-#include <EGL/egl.h>
-
 #include "base/macros.h"

[piman, 2016/02/23 23:37:16]

nit: the style guide puts system headers (in <>) before chrome headers (in ""),
so this was correct where it was.

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

+#include <EGL/egl.h>
 
 namespace egl {
 
 class Config {
  public:
-  Config();
+  Config(EGLint surface_type);

[piman, 2016/02/23 23:37:16]

nit: explicit

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

   ~Config();
-
+  bool matches(const EGLint* attrib_list) const;

[piman, 2016/02/23 23:37:16]

style nit: lower_with_underscore style is reserved for trivial inline functions
(e.g. setter/getters or <5 lines).

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

   bool GetAttrib(EGLint attribute, EGLint* value) const;
+  static bool ValidateAttributeList(const EGLint* attrib_list);
 
  private:
   // Total color component bits in the color buffer.