command_buffer_gles2: Implement EGL default Display as a global object

gpu/gles2_conform_support/egl/config.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_GLES2_CONFORM_TEST_CONFIG_H_
 #define GPU_GLES2_CONFORM_TEST_CONFIG_H_
 
+#include "base/macros.h"

[piman, 2016/02/23 23:37:16]

nit: the style guide puts system headers (in <>) before chrome headers (in ""),
so this was correct where it was.

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

 #include <EGL/egl.h>
 
-#include "base/macros.h"
-
 namespace egl {
 
 class Config {
  public:
-  Config();
+  Config(EGLint surface_type);

[piman, 2016/02/23 23:37:16]

nit: explicit

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

   ~Config();
-
+  bool matches(const EGLint* attrib_list) const;

[piman, 2016/02/23 23:37:16]

style nit: lower_with_underscore style is reserved for trivial inline functions
(e.g. setter/getters or <5 lines).

[Kimmo Kinnunen, 2016/02/24 07:33:26]

Done.

   bool GetAttrib(EGLint attribute, EGLint* value) const;
+  static bool ValidateAttributeList(const EGLint* attrib_list);
 
  private:
   // Total color component bits in the color buffer.
   EGLint buffer_size_;
   // Bits of Red in the color buffer.
   EGLint red_size_;
   // Bits of Green in the color buffer.
   EGLint green_size_;
   // Bits of Blue in the color buffer.
   EGLint blue_size_;
@@ skipping 53 matching lines @@
   EGLint transparent_green_value_;
   // Transparent blue value
   EGLint transparent_blue_value_;
 
   DISALLOW_COPY_AND_ASSIGN(Config);
 };
 
 }  // namespace egl
 
 #endif  // GPU_GLES2_CONFORM_TEST_CONFIG_H_