Show the extension / app name for platform verification.

Show the extension / app name for platform verification.

The platform verification dialog communicates to the user the origin of
the request.  Normally this is a web origin but for extensions or v2
apps the web origin is ugly and the extension / app name is better.

BUG=chromium:344723
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252126

[not at google - send to devlin, 2014-02-19 03:37:21]

lgtm

https://codereview.chromium.org/171483003/diff/1/chrome/browser/chromeos/atte...
File chrome/browser/chromeos/attestation/platform_verification_dialog.cc
(right):

https://codereview.chromium.org/171483003/diff/1/chrome/browser/chromeos/atte...
chrome/browser/chromeos/attestation/platform_verification_dialog.cc:47:
extension_service()->GetInstalledExtensionByUrl(url);
could you use ExtensionRegistry instead? we're trying to reduce the usage of
ExtensionService.

const extensions::Extension* extension =
    extensions::ExtensionRegistry::Get(web_contents->GetBrowserContext())->
        enabled_extensions()->GetExtensionOrAppByURL(url);

consider using ternary-if for |origin|, but, up to you.

[Mattias Nissler (ping if slow), 2014-02-19 08:18:35]

rubber stamp LGTM.

[Darren Krahn, 2014-02-19 18:11:25]

https://codereview.chromium.org/171483003/diff/1/chrome/browser/chromeos/atte...
File chrome/browser/chromeos/attestation/platform_verification_dialog.cc
(right):

https://codereview.chromium.org/171483003/diff/1/chrome/browser/chromeos/atte...
chrome/browser/chromeos/attestation/platform_verification_dialog.cc:47:
extension_service()->GetInstalledExtensionByUrl(url);
On 2014/02/19 03:37:21, kalman wrote:
> could you use ExtensionRegistry instead? we're trying to reduce the usage of
> ExtensionService.
> 
> const extensions::Extension* extension =
>     extensions::ExtensionRegistry::Get(web_contents->GetBrowserContext())->
>         enabled_extensions()->GetExtensionOrAppByURL(url);
> 
> consider using ternary-if for |origin|, but, up to you.

Done.

[Darren Krahn, 2014-02-19 18:13:17]

The CQ bit was checked by dkrahn@chromium.org

[commit-bot: I haz the power, 2014-02-19 18:16:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dkrahn@chromium.org/171483003/70001

[commit-bot: I haz the power, 2014-02-19 23:15:37]

Change committed as 252126