Show the extension / app name for platform verification.

chrome/browser/chromeos/attestation/platform_verification_dialog.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/attestation/platform_verification_dialog.h"
 
 #include "base/strings/utf_string_conversions.h"
+#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/common/url_constants.h"
 #include "components/web_modal/web_contents_modal_dialog_host.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
 #include "content/public/browser/web_contents.h"
+#include "extensions/browser/extension_system.h"
+#include "extensions/common/extension.h"
 #include "grit/generated_resources.h"
 #include "ui/aura/window.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/border.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/layout/fill_layout.h"
 #include "ui/views/layout/layout_constants.h"
 #include "ui/views/widget/widget.h"
 
 namespace chromeos {
 namespace attestation {
 
 namespace {
 
 const int kDialogMaxWidthInPixel = 400;
 
 }  // namespace
 
 // static
 void PlatformVerificationDialog::ShowDialog(
     content::WebContents* web_contents,
     const PlatformVerificationFlow::Delegate::ConsentCallback& callback) {
-  std::string origin = web_contents->GetLastCommittedURL().GetOrigin().spec();
+  GURL url = web_contents->GetLastCommittedURL();
+  std::string origin = url.GetOrigin().spec();
+  // In the case of an extension or hosted app, the origin of the request is
+  // best described by the extension / app name.
+  const extensions::Extension* extension =
+      extensions::ExtensionSystem::Get(web_contents->GetBrowserContext())->
+          extension_service()->GetInstalledExtensionByUrl(url);

[not at google - send to devlin, 2014/02/19 03:37:21]

could you use ExtensionRegistry instead? we're trying to reduce the usage of
ExtensionService.

const extensions::Extension* extension =
    extensions::ExtensionRegistry::Get(web_contents->GetBrowserContext())->
        enabled_extensions()->GetExtensionOrAppByURL(url);

consider using ternary-if for |origin|, but, up to you.

[Darren Krahn, 2014/02/19 18:11:26]

Done.

+  if (extension)
+    origin = extension->name();
 
   PlatformVerificationDialog* dialog = new PlatformVerificationDialog(
       chrome::FindBrowserWithWebContents(web_contents),
       base::UTF8ToUTF16(origin),
       callback);
 
   // Sets up the dialog widget and shows it.
   web_modal::WebContentsModalDialogManager* web_contents_modal_dialog_manager =
       web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);
   web_modal::WebContentsModalDialogManagerDelegate* modal_delegate =
@@ skipping 62 matching lines @@
 }
 
 void PlatformVerificationDialog::StyledLabelLinkClicked(const gfx::Range& range,
                                                         int event_flags) {
   chrome::ShowSingletonTab(browser_, GURL(
       chrome::kEnhancedPlaybackNotificationLearnMoreURL));
 }
 
 }  // namespace attestation
 }  // namespace chromeos