7/ Eliminate on_application_end from ConnectParams

Eliminate on_application_end from ConnectParams

BUG=

Committed: https://crrev.com/9dc1788c04765502f91997639c3044e6ca5a1f5c
Cr-Commit-Position: refs/heads/master@{#376655}

[Ben Goodger (Google), 2016-02-19 00:59:01]

ben@chromium.org changed reviewers:
+ sky@chromium.org

[Ben Goodger (Google), 2016-02-19 03:28:31]

Description was changed from

==========
Eliminate on_application_end from ConnectParams

BUG=
==========

to

==========
Eliminate on_application_end from ConnectParams

BUG=
==========

[sky, 2016-02-19 05:20:51]

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/application_...
File mojo/shell/application_manager.h (right):

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/application_...
mojo/shell/application_manager.h:74: void
SetInstanceQuitCallback(base::Callback<void(const Identity&)> callback);
Document what this means.

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/c...
File mojo/shell/standalone/context.cc (right):

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/c...
mojo/shell/standalone/context.cc:94:
base::MessageLoop::current()->QuitWhenIdle();
Ick, quitting arbitrary messageloop is error prone. But the old code was doing
this too. 

The old code would only quit once all the urls started complete. AFAICT you quit
once the last url completes.

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/c...
mojo/shell/standalone/context.cc:222:
application_manager_->SetInstanceQuitCallback(
If Run() is called multiple-times doesn't the new call to
SetInstanceQuitCallback clobber the old value (there is only one callback).

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/d...
File mojo/shell/standalone/desktop/launcher_process.cc (right):

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/d...
mojo/shell/standalone/desktop/launcher_process.cc:51: message_loop.Run();
I think RunCommandLineApplication should be responsible for starting the
messageloop. That way it can have a Runloop and the Runloop Context creates can
be quit when done. That way nested message loops still work fine.

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/d...
File mojo/shell/standalone/desktop/main_helper.h (right):

https://codereview.chromium.org/1714753002/diff/40001/mojo/shell/standalone/d...
mojo/shell/standalone/desktop/main_helper.h:15: // |callback| is only called in
the later case.
nit: remove comment about callback.

[Ben Goodger (Google), 2016-02-19 19:13:39]

I'm going to leave the message loops alone in this iteration, but updated
function names & documentation accordingly

[sky, 2016-02-19 20:52:53]

LGTM

[Ben Goodger (Google), 2016-02-20 17:16:42]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-20 17:16:43]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1714753002/#ps80001
(title: ".")

[commit-bot: I haz the power, 2016-02-20 17:16:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714753002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714753002/80001

[Ben Goodger (Google), 2016-02-20 17:18:10]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2016-02-20 17:18:11]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1714753002/#ps100001
(title: ".")

[commit-bot: I haz the power, 2016-02-20 17:18:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1714753002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1714753002/100001

[commit-bot: I haz the power, 2016-02-20 18:29:09]

Description was changed from

==========
Eliminate on_application_end from ConnectParams

BUG=
==========

to

==========
Eliminate on_application_end from ConnectParams

BUG=
==========

[commit-bot: I haz the power, 2016-02-20 18:29:10]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-02-20 18:30:09]

Description was changed from

==========
Eliminate on_application_end from ConnectParams

BUG=
==========

to

==========
Eliminate on_application_end from ConnectParams

BUG=

Committed: https://crrev.com/9dc1788c04765502f91997639c3044e6ca5a1f5c
Cr-Commit-Position: refs/heads/master@{#376655}
==========

[commit-bot: I haz the power, 2016-02-20 18:30:10]

Patchset 6 (id:??) landed as
https://crrev.com/9dc1788c04765502f91997639c3044e6ca5a1f5c
Cr-Commit-Position: refs/heads/master@{#376655}