7/ Eliminate on_application_end from ConnectParams

mojo/shell/standalone/desktop/launcher_process.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 #include <string.h>
 
-#include <algorithm>
 #include <iostream>
 
 #include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/debug/stack_trace.h"
 #include "base/files/file_util.h"
 #include "base/i18n/icu_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/path_service.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/threading/platform_thread.h"
 #include "mojo/shell/standalone/context.h"
 #include "mojo/shell/switches.h"
 
 namespace mojo {
 namespace shell {
 
-int LauncherProcessMain(const GURL& mojo_url, const base::Closure& callback) {
+int LauncherProcessMain() {
 #if !defined(OFFICIAL_BUILD)
   base::debug::EnableInProcessStackDumping();
 #endif
   base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
   // http://crbug.com/546644
   command_line->AppendSwitch(switches::kNoSandbox);
 
   base::PlatformThread::SetName("mojo_runner");
 
   // We want the Context to outlive the MessageLoop so that pipes are all
   // gracefully closed / error-out before we try to shut the Context down.
   Context shell_context;
   {
     base::MessageLoop message_loop;
     base::FilePath shell_dir;
     PathService::Get(base::DIR_MODULE, &shell_dir);
     CHECK(base::i18n::InitializeICU());
     shell_context.Init(shell_dir);
 
-    if (mojo_url.is_empty()) {
-      message_loop.PostTask(
-          FROM_HERE,
-          base::Bind(&Context::RunCommandLineApplication,
-                     base::Unretained(&shell_context), base::Closure()));
-    } else {
-      message_loop.PostTask(
-          FROM_HERE, base::Bind(&mojo::shell::Context::Run,
-                                base::Unretained(&shell_context), mojo_url));
-    }
+    message_loop.PostTask(
+        FROM_HERE,
+        base::Bind(&Context::RunCommandLineApplication,
+                    base::Unretained(&shell_context)));
+
     message_loop.Run();

[sky, 2016/02/19 05:20:51]

I think RunCommandLineApplication should be responsible for starting the
messageloop. That way it can have a Runloop and the Runloop Context creates can
be quit when done. That way nested message loops still work fine.

 
     // Must be called before |message_loop| is destroyed.
     shell_context.Shutdown();
   }
 
   return 0;
 }
 
 }  // namespace shell
 }  // namespace mojo