VM: Separate precompilation-specific code, make flags const.

runtime/vm/flag_list.h

Index: runtime/vm/flag_list.h
diff --git a/runtime/vm/flag_list.h b/runtime/vm/flag_list.h
index 259d09b115598a345939f3945aeacec2fc1768c3..c0e00c96e29eeb0718330ea4aaab0a41c80b8316 100644
--- a/runtime/vm/flag_list.h
+++ b/runtime/vm/flag_list.h
@@ -13,7 +13,7 @@
 //   enabled.
 // * R elease flags: Generally available flags except when building product.

[rmacnak, 2016/02/19 00:54:31]

* pre C ompiled flags: ...

[Florian Schneider, 2016/02/19 17:42:29]

Done.

[rmacnak, 2016/02/19 00:54:31]

What about features disabled by product mode or precompilation?
E.g., --support_debugger?  Is it worth making theses constant in precompiled +
release, or is precompiled + product enough?

[Florian Schneider, 2016/02/19 17:42:29]

I added all 4 combinations of product/precompiled runtime

The "C" macro allow to specify two constant values, and one default value for
non-product/non-precompiled.

-#define FLAG_LIST(P, R, D)                                                     \
+#define FLAG_LIST(P, R, D, C)                                                  \
 R(dedup_instructions, true, bool, false,                                       \
   "Canonicalize instructions when precompiling.")                              \
 R(disable_alloc_stubs_after_gc, false, bool, false,                            \
@@ -62,6 +62,7 @@ R(verify_after_gc, false, bool, false,                                         \
   "Enables heap verification after GC.")                                       \
 R(verify_before_gc, false, bool, false,                                        \
   "Enables heap verification before GC.")                                      \
+C(lazy_dispatchers, false, bool, true, "Generate dispatchers lazily")          \

[Ivan Posva, 2016/02/19 01:07:49]

Two lines for all of them! Even if they fit, which greatly improves readability.

Also please note the alphabetical order.

[Florian Schneider, 2016/02/19 17:42:29]

Done.

 
 
 #endif  // VM_FLAG_LIST_H_