VM: Separate precompilation-specific code, make flags const.

runtime/vm/flag_list.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_FLAG_LIST_H_
 #define VM_FLAG_LIST_H_
 
 // List of all flags in the VM.
 // Flags can be one of three categories:
 // * P roduct flags: Can be set in any of the deployment modes, including in
 //   production.
 // * D ebug flags: Can only be set in debug VMs, which also have assertions
 //   enabled.
 // * R elease flags: Generally available flags except when building product.

[rmacnak, 2016/02/19 00:54:31]

* pre C ompiled flags: ...

[Florian Schneider, 2016/02/19 17:42:29]

Done.

[rmacnak, 2016/02/19 00:54:31]

What about features disabled by product mode or precompilation?
E.g., --support_debugger?  Is it worth making theses constant in precompiled +
release, or is precompiled + product enough?

[Florian Schneider, 2016/02/19 17:42:29]

I added all 4 combinations of product/precompiled runtime

The "C" macro allow to specify two constant values, and one default value for
non-product/non-precompiled.

-#define FLAG_LIST(P, R, D)                                                     \
+#define FLAG_LIST(P, R, D, C)                                                  \
 R(dedup_instructions, true, bool, false,                                       \
   "Canonicalize instructions when precompiling.")                              \
 R(disable_alloc_stubs_after_gc, false, bool, false,                            \
   "Stress testing flag.")                                                      \
 R(disassemble, false, bool, false,                                             \
   "Disassemble dart code.")                                                    \
 R(disassemble_optimized, false, bool, false,                                   \
   "Disassemble optimized code.")                                               \
 R(dump_symbol_stats, false, bool, false,                                       \
   "Dump symbol table statistics")                                              \
@@ skipping 28 matching lines @@
 D(trace_zones, bool, false,                                                    \
   "Traces allocation sizes in the zone.")                                      \
 P(verbose_gc, bool, false,                                                     \
   "Enables verbose GC.")                                                       \
 P(verbose_gc_hdr, int, 40,                                                     \
   "Print verbose GC header interval.")                                         \
 R(verify_after_gc, false, bool, false,                                         \
   "Enables heap verification after GC.")                                       \
 R(verify_before_gc, false, bool, false,                                        \
   "Enables heap verification before GC.")                                      \
+C(lazy_dispatchers, false, bool, true, "Generate dispatchers lazily")          \

[Ivan Posva, 2016/02/19 01:07:49]

Two lines for all of them! Even if they fit, which greatly improves readability.

Also please note the alphabetical order.

[Florian Schneider, 2016/02/19 17:42:29]

Done.

 
 
 #endif  // VM_FLAG_LIST_H_