VM: Separate precompilation-specific code, make flags const.

VM: Separate precompilation-specific code, make flags const.

Move optimizations for precompilation into separate file.

Remove precompilation-specific code from flow_graph_optimizer.cc.

Add precompilation-flags: They are const in the precompiled runtime. Started moving flags to use the new flag-definition macros.

Add libdart_lib_precompiled target.

Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime)

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/b870dafa4f04a117366292b5824739d8f1806fb0

[Florian Schneider, 2016-02-19 00:25:00]

Description was changed from

==========
VM: Separate precompilation-specific code, make flags const.

Move optimizations for precompilation into separate file.

Remove precompilation-specific code from flow_graph_optimizer.cc.

Add precompilation-flags: They are const in the precompiled runtime.

Add libdart_lib_precompiled target.

Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime)

BUG=
==========

to

==========
VM: Separate precompilation-specific code, make flags const.

Move optimizations for precompilation into separate file.

Remove precompilation-specific code from flow_graph_optimizer.cc.

Add precompilation-flags: They are const in the precompiled runtime. Started
moving flags to use the new flag-definition macros.

Add libdart_lib_precompiled target.

Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime)

BUG=
==========

[Florian Schneider, 2016-02-19 00:25:41]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Florian Schneider, 2016-02-19 00:29:03]

fschneider@google.com changed reviewers:
+ iposva@google.com

[Florian Schneider, 2016-02-19 00:29:04]

+iposva: ptal at the new flag-definition macro for precompiled code

[rmacnak, 2016-02-19 00:54:32]

https://codereview.chromium.org/1714743002/diff/1/runtime/dart-runtime.gyp
File runtime/dart-runtime.gyp (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/dart-runtime.gyp#ne...
runtime/dart-runtime.gyp:98: 'libdart_lib_precompiled',
precompiled_runtime

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:14: // * R elease flags: Generally available flags except
when building product.
* pre C ompiled flags: ...

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:15: 
What about features disabled by product mode or precompilation?
E.g., --support_debugger?  Is it worth making theses constant in precompiled +
release, or is precompiled + product enough?

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:141: ASSERT(!FLAG_lazy_dispatchers);
COMPILE_ASSERT ?

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_inlin...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_inlin...
runtime/vm/flow_graph_inliner.cc:814: FlowGraphOptimizer optimizer(callee_graph,
Maybe this should be JitOptimizer for clarity.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/vm.gypi#newcode384
runtime/vm/vm.gypi:384: 'target_name': 'libdart_lib_precompiled',
precompiled_runtime

[Ivan Posva, 2016-02-19 01:07:50]

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/aot_optimizer.cc
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/aot_optimizer.cc...
runtime/vm/aot_optimizer.cc:32: DECLARE_FLAG(bool, guess_icdata_cid);
Please move these to flag_list.h so that we keep reducing the amount of
distributed flags. Thanks!

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:65: C(lazy_dispatchers, false, bool, true, "Generate
dispatchers lazily")          \
Two lines for all of them! Even if they fit, which greatly improves readability.

Also please note the alphabetical order.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flags.h
File runtime/vm/flags.h (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flags.h#newcode124
runtime/vm/flags.h:124: #if defined(DART_PRECOMPILED_RUNTIME)
As discussed we need to have a way for a flag to be unchangeable even in
non-precompiled product.

[Florian Schneider, 2016-02-19 17:42:29]

https://codereview.chromium.org/1714743002/diff/1/runtime/dart-runtime.gyp
File runtime/dart-runtime.gyp (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/dart-runtime.gyp#ne...
runtime/dart-runtime.gyp:98: 'libdart_lib_precompiled',
On 2016/02/19 00:54:31, rmacnak wrote:
> precompiled_runtime

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/aot_optimizer.cc
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/aot_optimizer.cc...
runtime/vm/aot_optimizer.cc:32: DECLARE_FLAG(bool, guess_icdata_cid);
On 2016/02/19 01:07:49, Ivan Posva wrote:
> Please move these to flag_list.h so that we keep reducing the amount of
> distributed flags. Thanks!

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:14: // * R elease flags: Generally available flags except
when building product.
On 2016/02/19 00:54:31, rmacnak wrote:
> * pre C ompiled flags: ...

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:15: 
On 2016/02/19 00:54:31, rmacnak wrote:
> What about features disabled by product mode or precompilation?
> E.g., --support_debugger?  Is it worth making theses constant in precompiled +
> release, or is precompiled + product enough?

I added all 4 combinations of product/precompiled runtime

The "C" macro allow to specify two constant values, and one default value for
non-product/non-precompiled.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flag_list.h#newc...
runtime/vm/flag_list.h:65: C(lazy_dispatchers, false, bool, true, "Generate
dispatchers lazily")          \
On 2016/02/19 01:07:49, Ivan Posva wrote:
> Two lines for all of them! Even if they fit, which greatly improves
readability.
> 
> Also please note the alphabetical order.

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flags.h
File runtime/vm/flags.h (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flags.h#newcode124
runtime/vm/flags.h:124: #if defined(DART_PRECOMPILED_RUNTIME)
On 2016/02/19 01:07:49, Ivan Posva wrote:
> As discussed we need to have a way for a flag to be unchangeable even in
> non-precompiled product.

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.cc:141: ASSERT(!FLAG_lazy_dispatchers);
On 2016/02/19 00:54:31, rmacnak wrote:
> COMPILE_ASSERT ?

Done.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_inlin...
File runtime/vm/flow_graph_inliner.cc (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/flow_graph_inlin...
runtime/vm/flow_graph_inliner.cc:814: FlowGraphOptimizer optimizer(callee_graph,
On 2016/02/19 00:54:32, rmacnak wrote:
> Maybe this should be JitOptimizer for clarity.

Ack. Will do this in a separate CL to not blow this one up by too much renaming.

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/1714743002/diff/1/runtime/vm/vm.gypi#newcode384
runtime/vm/vm.gypi:384: 'target_name': 'libdart_lib_precompiled',
On 2016/02/19 00:54:32, rmacnak wrote:
> precompiled_runtime

Done.

[rmacnak, 2016-02-19 23:46:04]

lgtm

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2048: ASSERT(FLAG_precompilation);
Keep comment: Cannot handle unboxed instructions.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2056: ASSERT(FLAG_precompilation);
Keep comment

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2064: ASSERT(FLAG_precompilation);
Keep comment

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:86: P(use_cha_deopt, bool, true,                         
                         \
Constant false in precompilation, maybe a later CL.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:135: FLAG_polymorphic_with_deopt = false;
use_cha_deopt

[Florian Schneider, 2016-02-23 15:27:03]

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
File runtime/vm/aot_optimizer.cc (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2048: ASSERT(FLAG_precompilation);
On 2016/02/19 23:46:03, rmacnak wrote:
> Keep comment: Cannot handle unboxed instructions.

Done.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2056: ASSERT(FLAG_precompilation);
On 2016/02/19 23:46:04, rmacnak wrote:
> Keep comment

Done.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/aot_optimize...
runtime/vm/aot_optimizer.cc:2064: ASSERT(FLAG_precompilation);
On 2016/02/19 23:46:03, rmacnak wrote:
> Keep comment

Done.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flag_list.h
File runtime/vm/flag_list.h (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flag_list.h#...
runtime/vm/flag_list.h:86: P(use_cha_deopt, bool, true,                         
                         \
On 2016/02/19 23:46:04, rmacnak wrote:
> Constant false in precompilation, maybe a later CL.

Done.

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flow_graph_c...
File runtime/vm/flow_graph_compiler.cc (right):

https://codereview.chromium.org/1714743002/diff/20001/runtime/vm/flow_graph_c...
runtime/vm/flow_graph_compiler.cc:135: FLAG_polymorphic_with_deopt = false;
On 2016/02/19 23:46:04, rmacnak wrote:
> use_cha_deopt

Done.

[Florian Schneider, 2016-02-23 16:48:13]

Description was changed from

==========
VM: Separate precompilation-specific code, make flags const.

Move optimizations for precompilation into separate file.

Remove precompilation-specific code from flow_graph_optimizer.cc.

Add precompilation-flags: They are const in the precompiled runtime. Started
moving flags to use the new flag-definition macros.

Add libdart_lib_precompiled target.

Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime)

BUG=
==========

to

==========
VM: Separate precompilation-specific code, make flags const.

Move optimizations for precompilation into separate file.

Remove precompilation-specific code from flow_graph_optimizer.cc.

Add precompilation-flags: They are const in the precompiled runtime. Started
moving flags to use the new flag-definition macros.

Add libdart_lib_precompiled target.

Define PRECOMPILED_RUNTIME_MACRO in more places (dart_precompiled_runtime)

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b870dafa4f04a117366292b5824739d8f1806fb0
==========

[Florian Schneider, 2016-02-23 16:48:14]

Committed patchset #4 (id:60001) manually as
b870dafa4f04a117366292b5824739d8f1806fb0 (presubmit successful).