third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h - Issue 1714663002: Attempt to fix the crash in blink Scroll Animator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

Issue 1714663002: Attempt to fix the crash in blink Scroll Animator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added WILL_BE_USING_PRE_FINALIZER Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

index 50cc5f2fa8d2e53c843283a927839657cc794872..c83af75dc434757327f0f4838dd506e21f982bb7 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.h

@@ -52,8 +52,6 @@ public:

virtual ~ScrollAnimatorBase();

- virtual void dispose() { }

// Computes a scroll destination for the given parameters. The returned

// ScrollResultOneDimensional will have didScroll set to false if already at

// the destination. Otherwise, starts scrolling towards the destination and