Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 1714663002: Attempt to fix the crash in blink Scroll Animator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added WILL_BE_USING_PRE_FINALIZER Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
index f91bc0ff01e9bbcd0b41e2c11f60264744ee9243..8ab050ed1c1bb8afa4729f5dff72104817507529 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp
@@ -94,7 +94,7 @@ ScrollableArea::~ScrollableArea()
void ScrollableArea::clearScrollAnimators()
{
-#if OS(MACOSX) && ENABLE(OILPAN)
ajuma 2016/02/22 15:15:01 Instead of using an #if, WDYT of adding a virtual
bokan 2016/02/22 15:55:35 Why do we need to manually call dispose here at al
ymalik 2016/02/22 19:22:56 I think they have this call here because if oilpan
bokan 2016/02/22 19:35:46 The only place I see this being called from is Pai
+#if ENABLE(OILPAN)
if (m_scrollAnimator)
m_scrollAnimator->dispose();
#endif

Powered by Google App Engine
This is Rietveld 408576698