third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h - Issue 1714663002: Attempt to fix the crash in blink Scroll Animator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h

Issue 1714663002: Attempt to fix the crash in blink Scroll Animator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added WILL_BE_USING_PRE_FINALIZER Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h

diff --git a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h

index cd4e8d2170a21e9b1a63b7ef761ba86be2f7bac7..f4ba619aba1efc2a45e9994ee8a3ee89761c0565 100644

--- a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h

+++ b/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.h

@@ -45,7 +45,6 @@ namespace blink {

class Scrollbar;

class PLATFORM_EXPORT ScrollAnimatorMac : public ScrollAnimatorBase {

- WILL_BE_USING_PRE_FINALIZER(ScrollAnimatorMac, dispose);

ajuma 2016/02/22 15:15:01 I'm not sure about this change. Is this because yo

ymalik 2016/02/22 19:22:56 You're right. This should stay.

public:

ScrollAnimatorMac(ScrollableArea*);

~ScrollAnimatorMac() override;