Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: components/app_modal_strings.grdp

Issue 1714573002: Remove the ability of webpages to specify strings for the onbeforeunload dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/app_modal/javascript_dialog_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/app_modal_strings.grdp
diff --git a/components/app_modal_strings.grdp b/components/app_modal_strings.grdp
index 09cd5ff616289a3ba885c2e67f0384fde031fd7a..0be1e6a2ec901aae72a9d0ba9fbcb103790356e0 100644
--- a/components/app_modal_strings.grdp
+++ b/components/app_modal_strings.grdp
@@ -22,8 +22,8 @@
<message name="IDS_BEFOREUNLOAD_MESSAGEBOX_TITLE" desc="Title for the 'before unload' dialog.">
Confirm Navigation
</message>
- <message name="IDS_BEFOREUNLOAD_MESSAGEBOX_FOOTER" desc="Text shown at the bottom of the dialog, after the message provided by the script.">
- Are you sure you want to leave this page?
+ <message name="IDS_BEFOREUNLOAD_MESSAGEBOX_MESSAGE" desc="Text shown as the message of the 'before unload' dialog.">
+ This page is warning you that if you leave this page, data may be lost. Are you sure you want to leave this page?
</message>
<message name="IDS_BEFOREUNLOAD_MESSAGEBOX_OK_BUTTON_LABEL" desc="The text on the button which navigates the user away from the page.">
Leave this Page
@@ -36,8 +36,8 @@
<message name="IDS_BEFORERELOAD_MESSAGEBOX_TITLE" desc="Title for the 'before reload' dialog.">
Confirm Reload
</message>
- <message name="IDS_BEFORERELOAD_MESSAGEBOX_FOOTER" desc="Text shown at the bottom of the dialog, after the message provided by the script.">
- Are you sure you want to reload this page?
+ <message name="IDS_BEFORERELOAD_MESSAGEBOX_MESSAGE" desc="Text shown as the message of the 'before reload' dialog.">
Charlie Reis 2016/02/18 21:37:13 nit: 'before unload' dialog for reloads. (There's
Avi (use Gerrit) 2016/02/18 21:42:26 Done.
+ This page is warning you that if you reload this page, data may be lost. Are you sure you want to reload this page?
</message>
<message name="IDS_BEFORERELOAD_MESSAGEBOX_OK_BUTTON_LABEL" desc="The text on the button which reloads the page.">
Reload this Page
« no previous file with comments | « components/app_modal/javascript_dialog_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698