third_party/WebKit/Source/core/frame/Deprecation.cpp - Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Deprecation.cpp

diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp

index 74f4e4dab664d5558f2ef2b857a4fec9e79f2f50..57920fa8d498284a2aa133fa6faa20062e0629e5 100644

--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp

+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp

@@ -341,12 +341,6 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)

case UseCounter::V8TouchEvent_InitTouchEvent_Method:

return replacedWillBeRemoved("'TouchEvent.initTouchEvent'", "the TouchEvent constructor", 53, "5730982598541312");

- case UseCounter::RTCPeerConnectionCreateAnswerLegacyNoFailureCallback:

- return "RTCPeerConnection.CreateAnswer without a failure callback is deprecated. The failure callback will be a required parameter in M50. See https://www.chromestatus.com/feature/5663288008376320 for more details";

- case UseCounter::RTCPeerConnectionCreateOfferLegacyNoFailureCallback:

- return "RTCPeerConnection.CreateOffer without a failure callback is deprecated. The failure callback will be a required parameter in M50. See https://www.chromestatus.com/feature/5663288008376320 for more details";

case UseCounter::ObjectObserve:

return willBeRemoved("'Object.observe'", 50, "6147094632988672");