Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt

Issue 1713953002: Report errors in RTCPeerConnection legacy functions via the the failure callback instead of excepti… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt
diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt
index a62c15bcbc9d755158e8331b27acc9542b790e79..8016c2a5d43c555e4c3eb2c338512aa75bdbb0a3 100644
--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt
+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-createOffer-expected.txt
@@ -3,19 +3,43 @@ Tests RTCPeerConnection createOffer.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS requestSucceeded was called.
+PASS testExecutionOrderClosedConnection() did not throw exception.
+PASS pc.createOffer(createOfferSucceeded1, unexpectedCallback, {voiceActivityDetection:true, iceRestart:true}); did not throw exception.
+PASS error.name is "InvalidStateError"
+PASS error.toString() is "InvalidStateError: The RTCPeerConnection's signalingState is 'closed'."
+PASS events is [1,2,3]
+PASS createOfferSucceeded1 was called.
PASS sessionDescription.type is "offer"
-PASS requestFailed was called.
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed1); did not throw exception.
+PASS expectedCreateOfferFailed1 was called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed2); did not throw exception.
+PASS expectedCreateOfferFailed2 was called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed3, {}); did not throw exception.
+PASS expectedCreateOfferFailed3 was called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed4, {voiceActivityDetection:false}); did not throw exception.
+PASS expectedCreateOfferFailed4 was called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(createOfferSucceeded2, unexpectedCallback, {iceRestart:true}); did not throw exception.
+PASS createOfferSucceeded2 was called.
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed5, {offerToReceiveVideo:1, offerToReceiveAudio:0, voiceActivityDetection:false, iceRestart:true}); did not throw exception.
+PASS expectedCreateOfferFailed5 was called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed6, {offerToReceiveVideo:-1, offerToReceiveAudio:0}); did not throw exception.
+PASS expectedCreateOfferFailed6 called.
+PASS error.name is "OperationError"
+PASS error.toString() is "OperationError: TEST_ERROR"
+PASS pc.createOffer(unexpectedCallback, expectedCreateOfferFailed7, {offerToReceiveVideo:0, offerToReceiveAudio:-1}); did not throw exception.
+PASS expectedCreateOfferFailed7 called.
PASS error.name is "OperationError"
PASS error.toString() is "OperationError: TEST_ERROR"
-PASS pc.createOffer(dummy, dummy); did not throw exception.
-PASS pc.createOffer(dummy, dummy, {}); did not throw exception.
-PASS pc.createOffer(dummy, dummy, {voiceActivityDetection:false}); did not throw exception.
-PASS pc.createOffer(dummy, dummy, {iceRestart:true}); did not throw exception.
-PASS pc.createOffer(dummy, dummy, {voiceActivityDetection:false, iceRestart:true}); did not throw exception.
-PASS pc.createOffer(dummy, dummy, {offerToReceiveVideo:-1, offerToReceiveAudio:0}); threw exception TypeError: Failed to execute 'createOffer' on 'RTCPeerConnection': Invalid offerToReceiveVideo.
-PASS pc.createOffer(dummy, dummy, {offerToReceiveVideo:0, offerToReceiveAudio:-1}); threw exception TypeError: Failed to execute 'createOffer' on 'RTCPeerConnection': Invalid offerToReceiveAudio.
-PASS pc.createOffer(dummy, dummy, {offerToReceiveVideo:1, offerToReceiveAudio:0, voiceActivityDetection:false, iceRestart:true}); did not throw exception.
PASS successfullyParsed is true
TEST COMPLETE

Powered by Google App Engine
This is Rietveld 408576698