Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1713853003: VM: Share object pool entries for optimized static calls. (Closed)

Created:
4 years, 10 months ago by rmacnak
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Share object pool entries for optimized static calls. Independently patchable entries are not required for debugging because breakpoints are only added to unoptimized code, nor for deopt because deopt patches the instruction stream and not the object pool. Future work: Reduce the static call table from (pc offset, function, code) triples to (pc offset, function or allocation stub) pairs. precompiled dart2js arm 20747140 -> 20674954 (-0.34%) R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/04e8382cec1605215728ecf58c701275d740f86f

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -94 lines) Patch
M runtime/vm/assembler.h View 5 chunks +32 lines, -5 lines 0 comments Download
M runtime/vm/assembler.cc View 3 chunks +15 lines, -8 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 4 chunks +47 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 4 chunks +46 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 4 chunks +48 lines, -18 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 4 chunks +46 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rmacnak
4 years, 10 months ago (2016-02-20 00:32:07 UTC) #3
Florian Schneider
Lgtm. For precompiled code we should investigate switching to direct calls of statics.
4 years, 10 months ago (2016-02-24 16:53:28 UTC) #4
rmacnak
4 years, 10 months ago (2016-02-24 21:57:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
04e8382cec1605215728ecf58c701275d740f86f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698