Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: runtime/vm/code_generator.cc

Issue 1713853003: VM: Share object pool entries for optimized static calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_generator.cc
diff --git a/runtime/vm/code_generator.cc b/runtime/vm/code_generator.cc
index 4f5b2a1028ad34e10e7204f221a29e80422aad43..4c20877a9a4aa4899ec035237ae209a77ceb6c78 100644
--- a/runtime/vm/code_generator.cc
+++ b/runtime/vm/code_generator.cc
@@ -1558,9 +1558,6 @@ DEFINE_RUNTIME_ENTRY(FixCallersTarget, 0) {
ASSERT(caller_code.is_optimized());
const Function& target_function = Function::Handle(
zone, caller_code.GetStaticCallTargetFunctionAt(frame->pc()));
- const Code& target_code = Code::Handle(
- zone, caller_code.GetStaticCallTargetCodeAt(frame->pc()));
- ASSERT(!target_code.IsNull());
if (!target_function.HasCode()) {
const Error& error = Error::Handle(
zone, Compiler::CompileFunction(thread, target_function));
@@ -1569,7 +1566,6 @@ DEFINE_RUNTIME_ENTRY(FixCallersTarget, 0) {
}
}
ASSERT(target_function.HasCode());
- ASSERT(target_function.raw() == target_code.function());
const Code& current_target_code = Code::Handle(
zone, target_function.CurrentCode());
@@ -1579,11 +1575,10 @@ DEFINE_RUNTIME_ENTRY(FixCallersTarget, 0) {
caller_code.SetStaticCallTargetCodeAt(frame->pc(), current_target_code);
if (FLAG_trace_patching) {
OS::PrintErr("FixCallersTarget: caller %#" Px " "
- "target '%s' %#" Px " -> %#" Px "\n",
- frame->pc(),
- target_function.ToFullyQualifiedCString(),
- target_code.EntryPoint(),
- current_target_code.EntryPoint());
+ "target '%s' -> %#" Px "\n",
+ frame->pc(),
+ target_function.ToFullyQualifiedCString(),
+ current_target_code.EntryPoint());
}
arguments.SetReturn(current_target_code);
}
« no previous file with comments | « runtime/vm/assembler_x64.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698