A thread-safe Media Query Parser

Source/core/css/MediaFeatureNames.h

Index: Source/core/css/MediaFeatureNames.h
diff --git a/Source/core/css/MediaFeatureNames.h b/Source/core/css/MediaFeatureNames.h
index 762437242b8840eae47bc24c9f9af38dcb7f913f..46bab7d2974684b404e0e648f501a691c66301dd 100644
--- a/Source/core/css/MediaFeatureNames.h
+++ b/Source/core/css/MediaFeatureNames.h
@@ -21,7 +21,7 @@
 #ifndef MediaFeatureNames_h
 #define MediaFeatureNames_h
 
-#include "wtf/text/AtomicString.h"
+#include "wtf/text/WTFString.h"
 
 namespace WebCore {
 namespace MediaFeatureNames {
@@ -73,7 +73,7 @@ namespace MediaFeatureNames {
 // end of macro
 
 #ifndef CSS_MEDIAQUERY_NAMES_HIDE_GLOBALS
-#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const AtomicString name##MediaFeature;
+#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const String name##MediaFeature;

[abarth-chromium, 2014/03/01 07:28:25]

Can you change this to be MediaFeatureNames.in and use make_names.py?  That's a
better pattern and will make thread-safe strings for you.

Take a look at how FontFamilyNames.in integrates with the build system to see
how that works.

 CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(CSS_MEDIAQUERY_NAMES_DECLARE)
 #undef CSS_MEDIAQUERY_NAMES_DECLARE
 #endif