A thread-safe Media Query Parser

Source/core/css/MediaFeatureNames.h

 /*
  * Copyright (C) 2005, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 #ifndef MediaFeatureNames_h
 #define MediaFeatureNames_h
 
-#include "wtf/text/AtomicString.h"
+#include "wtf/text/WTFString.h"
 
 namespace WebCore {
 namespace MediaFeatureNames {
 
 #define CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(macro) \
     macro(color, "color") \
     macro(colorIndex, "color-index") \
     macro(grid, "grid") \
     macro(monochrome, "monochrome") \
     macro(height, "height") \
@@ skipping 31 matching lines @@
     macro(resolution, "resolution") \
     macro(transform2d, "-webkit-transform-2d") \
     macro(transform3d, "-webkit-transform-3d") \
     macro(scan, "scan") \
     macro(animation, "-webkit-animation") \
     macro(viewMode, "-webkit-view-mode")
 
 // end of macro
 
 #ifndef CSS_MEDIAQUERY_NAMES_HIDE_GLOBALS
-#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const AtomicString name##MediaFeature;
+#define CSS_MEDIAQUERY_NAMES_DECLARE(name, str) extern const String name##MediaFeature;

[abarth-chromium, 2014/03/01 07:28:25]

Can you change this to be MediaFeatureNames.in and use make_names.py?  That's a
better pattern and will make thread-safe strings for you.

Take a look at how FontFamilyNames.in integrates with the build system to see
how that works.

 CSS_MEDIAQUERY_NAMES_FOR_EACH_MEDIAFEATURE(CSS_MEDIAQUERY_NAMES_DECLARE)
 #undef CSS_MEDIAQUERY_NAMES_DECLARE
 #endif
 
     void init();
 
 } // namespace MediaFeatureNames
 } // namespace WebCore
 
 #endif // MediaFeatureNames_h