Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1713783003:
DevTools: improve SCSS parser to correctly handle variable expansions (Closed)
|
Created:
4 years, 10 months ago by lushnikov Modified:
4 years, 10 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: improve SCSS parser to correctly handle variable expansions
The patch improves SCSS parser to not get stuck after encountering
variable expansion.
BUG=527993
R=pfeldman, dgozman
Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2
Cr-Commit-Position: refs/heads/master@{#376489}
Committed: https://crrev.com/30c1c42696819bfd3f77bb842bcfec52d25377b1
Cr-Commit-Position: refs/heads/master@{#376591}
Patch Set 1 #
Messages
Total messages: 26 (13 generated)
ptal
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713783003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
lgtm
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713783003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman ========== to ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1712363002/ by imcheng@chromium.org. The reason for reverting is: Broke WebKit Linux webkit_tests: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/6....
Message was sent while issue was closed.
Description was changed from ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ========== to ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ==========
I will try to re-land as this looks more like bot inconsistency.
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713783003/1
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was unchecked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713783003/1
Message was sent while issue was closed.
Description was changed from ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ========== to ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} ========== to ========== DevTools: improve SCSS parser to correctly handle variable expansions The patch improves SCSS parser to not get stuck after encountering variable expansion. BUG=527993 R=pfeldman, dgozman Committed: https://crrev.com/dca95714bf140aa7f672ee80ae25a14ea7295eb2 Cr-Commit-Position: refs/heads/master@{#376489} Committed: https://crrev.com/30c1c42696819bfd3f77bb842bcfec52d25377b1 Cr-Commit-Position: refs/heads/master@{#376591} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30c1c42696819bfd3f77bb842bcfec52d25377b1 Cr-Commit-Position: refs/heads/master@{#376591} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
