Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js

Issue 1713783003: DevTools: improve SCSS parser to correctly handle variable expansions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js b/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
index 7120d7f5a16e96014a63efd7c3e5693016a4291f..01adb686ba177e53f5be3e69fc494aa7e04aa0fc 100644
--- a/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
+++ b/third_party/WebKit/Source/devtools/front_end/sass/SASSSupport.js
@@ -70,7 +70,7 @@ WebInspector.SASSSupport.SCSSParserStates = {
VariableValue: "VariableValue",
MixinName: "MixinName",
MixinValue: "MixinValue",
- Media: "Media",
+ Media: "Media"
}
/**
@@ -139,7 +139,9 @@ WebInspector.SASSSupport._innerParseSCSS = function(document, tokenizerFactory)
}
break;
case States.VariableName:
- if (tokenValue === ")" && tokenType === UndefTokenType) {
+ if (tokenValue === "}" && tokenType === UndefTokenType) {
+ state = States.Initial;
+ } else if (tokenValue === ")" && tokenType === UndefTokenType) {
state = States.Initial;
} else if (tokenValue === ":" && tokenType === UndefTokenType) {
state = States.VariableValue;
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sass/test-ast-scss-6-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698