Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1713663002: Revert of Use displayName in Error.stack rendering if present. (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Use displayName in Error.stack rendering if present. (patchset #1 id:1 of https://codereview.chromium.org/1706823003/ ) Reason for revert: See Domenic's comment on the V8 bug. Original issue's description: > Use displayName in Error.stack rendering if present. > > BUG=v8:4761 > LOG=y > > Committed: https://crrev.com/953874e974037e7e96ef282a7078760ccc905878 > Cr-Commit-Position: refs/heads/master@{#34105} TBR=jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4761 Committed: https://crrev.com/594a1e1de352afc90438f86094c0c69d8706131f Cr-Commit-Position: refs/heads/master@{#34129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -41 lines) Patch
M src/api.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/js/messages.js View 4 chunks +9 lines, -14 lines 0 comments Download
M src/messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/messages.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/runtime/runtime.h View 3 chunks +2 lines, -1 line 0 comments Download
M src/runtime/runtime-internal.cc View 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/stack-traces-display-name.js View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Toon Verwaest
Created Revert of Use displayName in Error.stack rendering if present.
4 years, 10 months ago (2016-02-18 19:18:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713663002/1
4 years, 10 months ago (2016-02-18 19:18:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 19:19:04 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 19:19:19 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/594a1e1de352afc90438f86094c0c69d8706131f
Cr-Commit-Position: refs/heads/master@{#34129}

Powered by Google App Engine
This is Rietveld 408576698