src/api.cc - Issue 1713663002: Revert of Use displayName in Error.stack rendering if present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1713663002: Revert of Use displayName in Error.stack rendering if present. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 0aa10b82d0137fe0f04dedc04a1f12aa0de95e5a..93a688ee322306e2328e978d326cbef4b0d9fc45 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -4461,7 +4461,7 @@

}

auto func = i::Handle<i::JSFunction>::cast(self);

i::Handle<i::String> property_name =

- isolate->factory()->display_name_string();

+ isolate->factory()->NewStringFromStaticChars("displayName");

i::Handle<i::Object> value =

i::JSReceiver::GetDataProperty(func, property_name);

if (value->IsString()) {

« no previous file with comments | « no previous file | src/js/messages.js » ('j') | no next file with comments »