Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1713433002:
Moved macros into prtime.h (Closed)
|
Created:
4 years, 10 months ago by pkl (ping after 24h if needed) Modified:
4 years, 10 months ago CC:
chromium-reviews, vmpstr+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMoved macros into prtime.h
This is a followup to https://codereview.chromium.org/1657433002/ to
move the LL_* macros to prtime.h
Committed: https://crrev.com/9edd6947b3645ba82be2b92f4f9c5f55f88cbef8
Cr-Commit-Position: refs/heads/master@{#376709}
Patch Set 1 #
Total comments: 4
Patch Set 2 : moved location of macros #
Messages
Total messages: 21 (8 generated)
pkl@chromium.org changed reviewers: + sdefresne@chromium.org, wtc@chromium.org
Patch set 1 LGTM. I suggest a small change. Thanks! https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtime.h File base/third_party/nspr/prtime.h (right): https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtim... base/third_party/nspr/prtime.h:74: #define NSPR_API(__type) extern __type Please add the new macros here. https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtim... base/third_party/nspr/prtime.h:112: #define LL_SUB(r, a, b) ((r) = (a) - (b)) This is in the middle of the code copied from prtime.h. So I suggest a better place for the new macros above.
Thank you! Landing via CQ. https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtime.h File base/third_party/nspr/prtime.h (right): https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtim... base/third_party/nspr/prtime.h:74: #define NSPR_API(__type) extern __type On 2016/02/20 01:05:16, wtc wrote: > > Please add the new macros here. Acknowledged. https://codereview.chromium.org/1713433002/diff/1/base/third_party/nspr/prtim... base/third_party/nspr/prtime.h:112: #define LL_SUB(r, a, b) ((r) = (a) - (b)) On 2016/02/20 01:05:16, wtc wrote: > > This is in the middle of the code copied from prtime.h. So I suggest a better > place for the new macros above. Thank you for the review and suggestion! Code moved.
The CQ bit was checked by pkl@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wtc@chromium.org Link to the patchset: https://codereview.chromium.org/1713433002/#ps20001 (title: "moved location of macros")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
+sdefresne - CQ says needs a committer. Would that by you?
The CQ bit was checked by wtc@chromium.org
lgtm Patch set 2 LGTM. Let me try CQ it.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by sdefresne@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713433002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Moved macros into prtime.h This is a followup to https://codereview.chromium.org/1657433002/ to move the LL_* macros to prtime.h ========== to ========== Moved macros into prtime.h This is a followup to https://codereview.chromium.org/1657433002/ to move the LL_* macros to prtime.h Committed: https://crrev.com/9edd6947b3645ba82be2b92f4f9c5f55f88cbef8 Cr-Commit-Position: refs/heads/master@{#376709} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9edd6947b3645ba82be2b92f4f9c5f55f88cbef8 Cr-Commit-Position: refs/heads/master@{#376709} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
